[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

Gilles Caulier caulier.gilles at kdemail.net
Thu Jan 4 09:14:44 GMT 2007


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=139547         




------- Additional Comments From caulier.gilles kdemail net  2007-01-04 10:14 -------
SVN commit 619739 by cgilles:

digiKam from trunk : Improvment of Selection/Deselection of Tags in tree list view from Comments & Tags sidebar : add 2 new options sub popup-menu to Select/Deselect All/Parents/Childs tags. Refactoring of pop-up menu.
CCBUGS: 139547



 M  +26 -27    imagedescedittab.cpp  


--- trunk/extragear/graphics/digikam/libs/imageproperties/imagedescedittab.cpp #619738:619739
 @ -59,13 +59,13  @
 #include "albumdb.h"
 #include "album.h"
 #include "albumsettings.h"
+#include "albumthumbnailloader.h"
 #include "tagcreatedlg.h"
 #include "navigatebarwidget.h"
-#include "imageinfo.h"
 #include "ratingwidget.h"
-#include "imageattributeswatch.h"
-#include "albumthumbnailloader.h"
 #include "talbumlistview.h"
+#include "imageinfo.h"
+#include "imageattributeswatch.h"
 #include "imagedescedittab.h"
 #include "imagedescedittab.moc"
 
 @ -632,43 +632,42  @
 
     popmenu.insertSeparator(-1);
 
-    QPopupMenu allTagsMenu;
-    allTagsMenu.insertItem(i18n("Select "),     14);
-    allTagsMenu.insertItem(i18n("Deselect"),    15);
-    allTagsMenu.insertItem(i18n("Invert"),      16);
-    popmenu.insertItem(i18n("All Tags"), &allTagsMenu);
+    QPopupMenu selectTagsMenu;
+    selectTagsMenu.insertItem(i18n("All"),       14);
+    selectTagsMenu.insertItem(i18n("Childs"),    17);
+    selectTagsMenu.insertItem(i18n("Parents"),   19);
+    popmenu.insertItem(i18n("Select"), &selectTagsMenu);
 
-    QPopupMenu childTagsMenu;
-    childTagsMenu.insertItem(i18n("Select"),    17);
-    childTagsMenu.insertItem(i18n("Deselect"),  18);
-    popmenu.insertItem(i18n("Childs Tags"), &childTagsMenu);
+    QPopupMenu deselectTagsMenu;
+    deselectTagsMenu.insertItem(i18n("All"),     15);
+    deselectTagsMenu.insertItem(i18n("Childs"),  18);
+    deselectTagsMenu.insertItem(i18n("Parents"), 20);
+    popmenu.insertItem(i18n("Deselect"), &deselectTagsMenu);
 
-    QPopupMenu parentTagsMenu;
-    parentTagsMenu.insertItem(i18n("Select"),   19);
-    parentTagsMenu.insertItem(i18n("Deselect"), 20);
-    popmenu.insertItem(i18n("Parent Tags"), &parentTagsMenu);
-    
+
+    popmenu.insertItem(i18n("Invert Selection"), 16);
+
     int choice = popmenu.exec((QCursor::pos()));
     switch( choice )
     {
-        case 10:
+        case 10:   // New Tag.
         {
             tagNew(album);
             break;
         }
-        case 11:
+        case 11:   // Edit Tag Properties.
         {
             if (!album->isRoot())
                 tagEdit(album);
             break;
         }
-        case 12:
+        case 12:   // Delete Tag.
         {
             if (!album->isRoot())
                 tagDelete(album);
             break;
         }
-        case 13:
+        case 13:   // Reset Tag Icon.
         {
             QString errMsg;
             AlbumManager::instance()->updateTAlbumIcon(album, QString("tag"), 0, errMsg);
 @ -698,7 +697,7  @
             }
             break;
         }
-        case 16:  // Invert All Tags Selection.
+        case 16:   // Invert All Tags Selection.
         {
             QListViewItemIterator it(d->tagsView);
             while (it.current())
 @ -715,22 +714,22  @
             }
             break;
         }
-        case 17:    // Select Child Tags.
+        case 17:   // Select Child Tags.
         {
             toggleChildTags(album, true);
             break;
         }
-        case 18:    // Deselect Child Tags.
+        case 18:   // Deselect Child Tags.
         {
             toggleChildTags(album, false);
             break;
         }
-        case 19:    // Select Parent Tags.
+        case 19:   // Select Parent Tags.
         {
             toggleParentTags(album, true);
             break;
         }
-        case 20:    // Deselect Parent Tags.
+        case 20:   // Deselect Parent Tags.
         {
             toggleParentTags(album, false);
             break;
 @ -822,7 +821,7  @
     {
         KMessageBox::error(this, i18n("You are currently viewing items in the "
                                       "tag '%1' that you are about to delete. "
-                                      "You will need to close this dialog first "
+                                      "You will need to apply change first "
                                       "if you want to delete the tag." )
                            .arg(album->title()));
         return;



More information about the Digikam-devel mailing list