[Digikam-devel] [Bug 141786] confirmation dialog during rename to existing file does not work

[Frank Siegert]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=141786         




------- Additional Comments From hugelmopf web de  2007-02-25 00:27 -------
Created an attachment (id=19804)
 --> (http://bugs.kde.org/attachment.cgi?id=19804&action=view)
Patch for renaming images

I am attaching a patch, which fixes this (and followup issues):

1. Problem reported is fixed in dio.cpp line 164. KDE 3.5 API says,
open_RenameDlg wants two complete URLs.

2. With that fixed, renaming works, but updating the album view doesn't,
because ImageInfo still doesn't get the corrected new filename, but the
initially wanted (already existing) filename. So I removed the const qualifier
from the destination URL passed to DIO::renameFile, such that the corrected new
filename can be "returned" to the caller (ImageInfo in this case). Since this
function doesn't seem to be used anywhere else, I suppose, that change won't
introduce problems.

3. There seems to be a rather obvious bug in DIO::renameFile (dio.cpp line
145). We didn't get bitten yet, because we only renamed files within the same
directory, but in case that function is ever called with different source and
target directory, this should be fixed as in my patch.