[Digikam-devel] [Bug 141663] Keep getting prompted to Apply Comments

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=141663         




------- Additional Comments From marcel.wiesweg gmx de  2007-02-23 17:29 -------
SVN commit 636631 by mwiesweg:

Check that the text actually changed in slotCommentChanged

CCBUG: 141663


 M  +7 -1      imagedescedittab.cpp  


--- trunk/extragear/graphics/digikam/libs/imageproperties/imagedescedittab.cpp #636630:636631
 @ -457,7 +457,7  @
     // remove before final release
     if (d->ignoreImageAttributesWatch)
     {
-        kdWarning() << "ImageDescEditTab::slotApplyAllChanges(): re-entering from event loop!" << endl;
+        DWarning() << "ImageDescEditTab::slotApplyAllChanges(): re-entering from event loop!" << endl;
     }
 
     // we are now changing attributes ourselves
 @ -669,6 +669,12  @
 
 void ImageDescEditTab::slotCommentChanged()
 {
+    // we cannot trust that the text actually changed
+    // (there are bogus signals caused by spell checking, see bug 141663)
+    // so we have to check before marking the metadata as modified
+    if (d->hub.comment() == d->commentsEdit->text())
+        return;
+
     d->hub.setComment(d->commentsEdit->text());
     setMetadataWidgetStatus(d->hub.commentStatus(), d->commentsEdit);
     slotModified();