[Digikam-devel] [Bug 103350] original image is silently overwritten when saving (patch)

Arnd Baecker arnd.baecker at web.de
Thu Aug 23 11:08:57 BST 2007


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=103350         




------- Additional Comments From arnd.baecker web de  2007-08-23 12:08 -------
Gilles,  I just checked my patch in #59, it still applies and compiles
with current svn. 
However, it does not work anymore!
The reason seems to be that it is now first saving to 
a temporary file (why?) and then renamed!
At least that's how I interpret the output on the console:

digikam: Saving to :/home/ab/Pictures/AB/ijjakc.digikamtempfile.tmp (JPEG)
digikam: Dirty: /AB
digikam: Using LibJPEG quality compression value: 81
digikam: renaming to /home/ab/Pictures/AB/IMG_4658_.JPG
digikam: Dirty: /AB

Looking at the code, it seems to happen in 
  bool EditorWindow::moveFile()
So clearly something has changed (to address some other bug?) 

Of course, one could add a check in the moveFile operation,
but maybe this is too late already?

As the security of this bug is now bumped to grave (with which I fully agree!),
it should be really fixed as quickly as possible.



More information about the Digikam-devel mailing list