[Digikam-devel] extragear/graphics/digikam/digikam

Gilles Caulier caulier.gilles at free.fr
Wed Nov 22 11:43:02 GMT 2006


SVN commit 606923 by cgilles:

digikam from trunk : fix huge memory corruption relevant of a wrong deletion of data shared between preview kio-slave and digiKam.
Without this fix, digiKam is unstable with unsupported/broken pictures to show. It can crash everywhere with a non suitable backtrace.
I have working hard to find this problem.

I would to thanks again and again valgrind team who have provided a great debuging tool.

CCMAIL: digikam-devel at kde.org



 M  +0 -6      imagepreviewwidget.cpp  


--- trunk/extragear/graphics/digikam/digikam/imagepreviewwidget.cpp #606922:606923
@@ -141,12 +141,6 @@
 
 void ImagePreviewWidget::slotFailedImagePreview(const KURL&)
 {
-    if (!d->previewJob.isNull())
-    {
-        d->previewJob->kill();
-        d->previewJob = 0;
-    }
-
     d->preview = QImage();
     d->pixmap  = QPixmap(contentsRect().size());
     updatePixmap();



More information about the Digikam-devel mailing list