[Digikam-devel] extragear/graphics/digikam/libs/dimg/loaders

Caulier Gilles caulier.gilles at kdemail.net
Tue May 16 22:47:00 BST 2006


Le Mardi 16 Mai 2006 10:46 PM, Marcel Wiesweg a écrit :
> > > digikam from trunk:
> > > Use KProcess for RAW image loader.
> > > Loading can now be cleanly aborted.
> > >
> > > This is a good example that KProcess is not the perfect tool for use
> > > with our shiny new multithreaded loader because KProcess is not
> > > reentrant,
> >
> > Is QProcess with Qt 4.0 will be ?
>
> Qt4 QProcess looks much better. One more point to look forward to Qt4.

ok

>
> > > but there are more advantages (wraps all system programming) so that
> > > the necessary main thread indirections are ok.
> >
> > I don't understand exactly what you mean. Please, Can you explain better
> > ?
>
> What I meant to say is:
> KProcess wraps all low-level system programming. But since it is not
> reentrant, we have to send an event to the main thread to start the process
> from there.
> It is not perfect, but there are more advantages than disadvantages.

ok

>
> > > TODO:
> > > - implement fast loading specified in RAWDecodingSettings
> >
> > ok
> >
> > > - do we need to parse StdErr?
> >
> > yes. dcraw return an error message on the console when we trying to get
> > the embedded ICC color profile into RAW file and if none is found. Look
> > below :
> >
> > digikam: /home/gilles/Documents/photos/Test
> > Photograhs/RAW/MINOLTA-DYNAX5D.MRW : RAW file identified
> > digikam: Cannot load metadata using Exiv2 (This does not look like a TIFF
> > image)
> > Found MSB TIFF Header
> > <IFD> with 14 entries at offset 8
> > <EXIF> with 33 entries at offset 434
> > <MAKERNOTE> with 23 entries at offset 1004
> > digikam: Running dcraw command dcraw -c -4 -w -a -q 0 -p embed -o
> > '/home/gilles/Documents/ICCPROFILES/WideGamutRGB.icc'
> > '/home/gilles/Documents/photos/Test Photograhs/RAW/MINOLTA-DYNAX5D.MRW'
> > /home/gilles/Documents/photos/Test Photograhs/RAW/MINOLTA-DYNAX5D.MRW has
> > no embedded profile.
>
> Thats strange. Actually, the rawloader is receiving StdErr in
> slotReceivedStderr. Is the last line coming from dcraw?

yes, but perhaps not from stderr, perhaps stdout.

>
> > In fact, i need just a bool flag somewhere to see if an emebeded ICC
> > color profile have be found in RAW file. I will use this flag in
> > DImgInterface::slotImageLoaded() method to control better ICC color
> > management workflow with RAW file into image editor if 'Using Embeded
> > profile' option is enabled in RAW file decoding settings...
> >
> > Loading progress information into Histogram form Color sidebar tab is
> > broken... Why ?
>
> For me with current svn version, the color sidebar is disabled as a whole
> while the histogram is loading. Is that what you mean? 

Yes. Before, the histogram blinked during loading image... why the sidebar is 
disable ? I think to have unchanged something in... or... I will chek the 
code...

Gilles



More information about the Digikam-devel mailing list