[Digikam-devel] [Bug 125733] Enabling 'Always apply ICM profiles' can lead to suprising results

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=125733         




------- Additional Comments From caulier.gilles free fr  2006-05-13 12:34 -------
SVN commit 540385 by cgilles:

digiKam from trunk : if ICC profiles are used by dcraw during RAW file decoding instead digiKam workflow, well store output colorspace profile in DImg instance of image editor. nota: the output workspace is the same in both!

CCBUGS: 125733

 M  +21 -9     dimginterface.cpp  


--- trunk/extragear/graphics/digikam/utilities/imageeditor/canvas/dimginterface.cpp #540384:540385
 @ -216,7 +216,7  @
          * if a RAW image is loaded:
          * 
          ***************************************************************
-         * RAW ICC color   *    digiKam color   *     digiKam color    *
+         *  RAW ICC color  *    digiKam color   *     digiKam color    *
          *   correction    *     management     *      management      *
          * during decoding *       enable       *        disable       *
          ***************************************************************
 @ -226,18 +226,24  @
          *                 *                    *                      *
          *                 *  [enableICC = ON]  *  [enableICC = OFF]   *
          ***************************************************************
-         *                 *   digiKam ICC      *    If an embeded     *
-         *  Using embeded  *   workflow is      * profile is found in  *
-         *     profile     *     disable        * image, dcraw use it  *
-         *     (EMBED)     *                    * output profile=sRGB  *
+         *                 *    digiKam ICC     *    If an embeded     *
+         *  Using embeded  *     workflow is    * profile is found in  *
+         *     profile     *   disable. If an   * image, dcraw use it. *
+         *                 *   embeded color    *   The output color   *
+         *                 *  is found in RAW   *   space profile is   *
+         *                 * file, dcraw use it *         sRGB         *
+         *     (EMBED)     * The output profile *                      *
+         *                 * set in digiKam ICC *                      *
+         *                 *  settings will be  *                      *
+         *                 *    used by dcraw   *                      *
          *                 *                    *                      *
          *                 *  [enableICC = OFF] *  [enableICC = OFF]   *
          ***************************************************************
-         *                 *  Input and output  *                      *
-         *  Using digiKam  *   color profiles   *    nothing to do     *
+         *                 *  Input and output  *     nothing to do    *
+         *  Using digiKam  *   color profiles   *                      *
          *   ICC settings  *  from digiKam ICC  *                      *
          *  (USERPROFILE)  *  settings will be  *                      *
-         *                 *    used by dcraw   *                      *
+         *                 *   used by dcraw    *                      *
          *                 *                    *                      *
          *                 *  [enableICC = OFF] *  [enableICC = OFF]   *
          ***************************************************************
 @ -265,17 +271,23  @
                 case RawDecodingSettings::EMBED:
                 {
                     enableICC = false;
+                    // The workspace profile set in digiKam workflow have been used by dcraw to decode 
+                    // RAW picture saved. We store it into DImg instance.
+                    d->image.getICCProfilFromFile(QFile::encodeName(d->cmSettings->workspaceSetting));
                     break;
                 }
                 case RawDecodingSettings::USERPROFILE:
                 {
                     enableICC = false;
+                    // The workspace profile set in digiKam workflow have been used by dcraw to decode 
+                    // RAW picture saved. We store it into DImg instance.
+                    d->image.getICCProfilFromFile(QFile::encodeName(d->cmSettings->workspaceSetting));
                     break;
                 }
             }
             
             if (enableICC == false)            
-                kdWarning() << "ICC workflow have been disable with this image!" << endl;
+                kdWarning() << "digiKam ICC workflow have been disable with this image!" << endl;
         }    
 
         if (d->cmSettings->enableCMSetting && enableICC)