[Digikam-devel] extragear/graphics/digikam/libs/dimg

Gilles Caulier caulier.gilles at kdemail.net
Thu Jun 22 11:25:27 BST 2006 

On Thursday 22 June 2006 12:05, Gilles Caulier wrote:
> On Thursday 22 June 2006 11:54, Roy wrote:
> > On Thursday 22 June 2006 11:50, Gilles Caulier wrote:
> > > On Thursday 22 June 2006 11:42, Roy wrote:
> > > > On Thursday 22 June 2006 11:26, Gilles Caulier wrote:
> > > > > On Thursday 22 June 2006 11:23, Roy wrote:
> > > > > > On Thursday 22 June 2006 09:12, you wrote:
> > > > > > > On Wednesday 21 June 2006 22:33, you wrote:
> > > > > > > > On Wednesday 21 June 2006 22:18, you wrote:
> > > > > > > > > Le Mercredi 21 Juin 2006 22:08, Roy a écrit :
> > > > > > > > > > On Monday 19 June 2006 21:46, Gilles Caulier wrote:
> > > > > > > > > > > SVN commit 553041 by cgilles:
> > > > > > > > > > >
> > > > > > > > > > > digikam from trunk : DImg::ImageLoader : If no embedded
> > > > > > > > > > > ICC profile is available in RAW, JPEG, PNG, and TIFF,
> > > > > > > > > > > well try to use Exif metadata :
> > > > > > > > > > >
> > > > > > > > > > > - 1/ check "Exif.Image.InterColorProfile" exif tag
> > > > > > > > > > > witch can contains an ICC color-space profile. - 2/ if
> > > > > > > > > > > this tags is empty, check "Exif.Photo.ColorSpace" witch
> > > > > > > > > > > can indicate if the image have already converted in a
> > > > > > > > > > > color space : sRGB or AdobeRGB. In this case, use the
> > > > > > > > > > > right ICC color-space profile file available with
> > > > > > > > > > > digiKam.
> > > > > > > > > > >
> > > > > > > > > > > this way will prevent to re-convert again an image to a
> > > > > > > > > > > color-space if there is no ICC embedded profile
> > > > > > > > > > > available.
> > > > > > > > > >
> > > > > > > > > > After this commit (i think) RAW images in Image Editor
> > > > > > > > > > are shown too dark. It seems like the input profile for
> > > > > > > > > > my EOS 350d is ignored somehow. If I manually choose my
> > > > > > > > > > input profile in Image Editor -> Fix -> Color -> Color
> > > > > > > > > > Management my test image shows up correctly. (If the
> > > > > > > > > > embedded profile (sRGB) is used the image stays dark.)
> > > > > > > > > >
> > > > > > > > > > When commenting out the call to method
> > > > > > > > > > checkExifWorkingColorSpace() in rawloader.cpp everything
> > > > > > > > > > works as expected/before.
> > > > > > > > > >
> > > > > > > > > > Thank you very much for this great tool.
> > > > > > > > >
> > > > > > > > > Witch behaviour are you set in ICC setup ? The ICC color
> > > > > > > > > space selection dialog appears when you load a RAW file in
> > > > > > > > > editor ?
> > > > > > > >
> > > > > > > > My settings are:
> > > > > > > >    ask when open an ...
> > > > > > > >    workspace:  sRGB
> > > > > > > >    monitor:    sRGB
> > > > > > > >    input:      canon6
> > > > > > > >    soft proof: -
> > > > > > > >
> > > > > > > > After your commit the color space selection dialog does *not*
> > > > > > > > appear - probably because the embedded color profile matches
> > > > > > > > the workspace color profile (but somehow the input profile is
> > > > > > > > ignored).
> > > > > > > >
> > > > > > > > If I comment out the method call of checkExif... the dialog
> > > > > > > > appears saying there is no embedded profile, if I want to
> > > > > > > > apply the workspace profile (sRGB).
> > > > > > >
> > > > > > > Yes, but the problem is not in this method, but into the ICC
> > > > > > > filter implementation: input and output profiles have inverted
> > > > > > > in the implementation if an embedded profile is found. Fixed in
> > > > > > > svn.
> > > > > > >
> > > > > > > Please try again
> > > > > > >
> > > > > > > Gilles
> > > > > >
> > > > > > Unfortunately the problem persists for me. If I click on a raw
> > > > > > image (without waiting for the histogram to load; if I would,
> > > > > > digikam eats all my memory -> see other thread "Image size) the
> > > > > > image in Image Editor is still too dark. I'm still not asked if i
> > > > > > want to apply a color profile.
> > > > >
> > > > > I cannot reproduce it now with my MRW files...
> > > > >
> > > > > In IO files settings / RAW decoding section, please select ICC
> > > > > color correction setting to disable... In fact this option must be
> > > > > removed.
> > > >
> > > > I don't use this option.
> > > >
> > > > Console messages of digikam:
> > > >
> > > > ----------------------------
> > > >
> > > > mrsheep at PM:~$ /home/mrsheep/opt/bin/digikam
> > > > Session management error: Could not open network socket
> > > > Session management error: Could not open network socket
> > > > kbuildsycoca running...
> > > > kded: WARNING: [KDEDModule* Kded::loadModule(const KService*, bool)]
> > > > Could not load library. [ libkat.so.0: cannot open shared object
> > > > file: No such file or directory ]
> > > > kded: WARNING: [KDEDModule* Kded::loadModule(const KService*, bool)]
> > > > Could not load library. [ Library files for
> > > > "libkded_katfilesystemdaemon.la" not found in paths. ]
> > > > KWrited - Listening on Device /dev/pts/9
> > > > digikam: ScanLib: Finding non-existing Albums: 4 ms
> > > > digikam: ScanLib: Finding items not in the database or disk: 189 ms
> > > > digikam: ScanLib: Updating items without date: 1 ms
> > > > digikam: Cannot parse EXIF metadata using Exiv2
> > > > digikam: digikampp: dipr
> > > > KIPI (loading): KIPI::PluginLoader: plugin KameraKlient is in the
> > > > ignore list for host application
> > > > KIPI (loading): Plugin_JPEGLossless plugin loaded
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin JPEGLossless
> > > > KIPI (loading): Plugin_CDArchiving plugin loaded
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin CDArchiving
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin ImagesGallery
> > > > KIPI (loading): Plugin_SendImages plugin loaded
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin SendImages
> > > > KIPI (loading): Plugin_FlickrExport plugin loaded
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin FlickrExport
> > > > KIPI (loading): Loaded Plugin_Calendar
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin Calendar
> > > > KIPI (loading): Plugin_Mpegencoder plugin loaded
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin MPEGEncoder
> > > > KIPI (loading): Plugin_AcquireImages plugin loaded
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin AcquireImages
> > > > KIPI (loading): Plugin_GalleryExport plugin loaded
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin GalleryExport
> > > > KIPI (loading): Plugin_TimeAdjust plugin loaded
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin TimeAdjust
> > > > KIPI (loading): Plugin_FindImages plugin loaded
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin FindImages
> > > > KIPI (loading): Plugin_PrintWizard plugin loaded
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin PrintWizard
> > > > KIPI (loading): Plugin_WallPaper plugin loaded
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin WallPaper
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin HTMLExport
> > > > KIPI (loading): Plugin_SlideShow plugin loaded
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin SlideShow
> > > > KIPI (loading): Plugin_BatchProcessImages plugin loaded
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin BatchProcessImages
> > > > KIPI (loading): Plugin_SimpleViewer plugin loaded
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin SimpleViewer
> > > > KIPI (loading): Loaded RawConverter
> > > > KIPI (loading): KIPI::PluginLoader: Loaded plugin RawConverter
> > > > digikam: ImagePlugin_Core plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_Core
> > > > digikam: ImagePlugin_RainDrop plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_RainDrop
> > > > digikam: ImagePlugin_InPainting plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_InPainting
> > > > digikam: ImagePlugin_Infrared plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_Infrared
> > > > digikam: ImagePlugin_Texture plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_Texture
> > > > digikam: ImagePlugin_Border plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_Border
> > > > digikam: ImagePlugin_OilPaint plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_OilPaint
> > > > digikam: ImagePlugin_InsertText plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_InsertText
> > > > digikam: ImagePlugin_Emboss plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_Emboss
> > > > digikam: ImagePlugin_NoiseReduction plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_NoiseReduction
> > > > digikam: ImagePlugin_Unsharp plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_Unsharp
> > > > digikam: ImagePlugin_HotPixels plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_HotPixels
> > > > digikam: ImagePlugin_AdjustLevels plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_AdjustLevels
> > > > digikam: ImagePlugin_ShearTool plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_ShearTool
> > > > digikam: ImagePlugin_Solarize plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_Solarize
> > > > digikam: ImagePlugin_DistortionFX plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_DistortionFX
> > > > digikam: ImagePlugin_LensDistortion plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_LensDistortion
> > > > digikam: ImagePlugin_FilmGrain plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_FilmGrain
> > > > digikam: ImagePlugin_BlowUp plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_BlowUp
> > > > digikam: ImagePlugin_Restoration plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_Restoration
> > > > digikam: ImagePlugin_SuperImpose plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_SuperImpose
> > > > digikam: ImagePlugin_Refocus plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_Refocus
> > > > digikam: ImagePlugin_WhiteBalance plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_WhiteBalance
> > > > digikam: ImagePlugin_BlurFX plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_BlurFX
> > > > digikam: ImagePlugin_AntiVignetting plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_AntiVignetting
> > > > digikam: ImagePlugin_AdjustCurves plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_AdjustCurves
> > > > digikam: ImagePlugin_FreeRotation plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_FreeRotation
> > > > digikam: ImagePlugin_Perspective plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_Perspective
> > > > digikam: ImagePlugin_ChannelMixer plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_ChannelMixer
> > > > digikam: ImagePlugin_Charcoal plugin loaded
> > > > digikam: ImagePluginLoader: Loaded plugin ImagePlugin_Charcoal
> > > > digikam: /media/sde3/bilder/digisvn/HochzeitSilvana2/IMG_3169_2.jpg :
> > > > JPEG file identified
> > > > digikam: Exif color-space tag is sRGB. Using default sRGB ICC
> > > > profile. digikam: ICC file: /home/mrsheep/dipr/canon6.icm ==> Input
> > > > device class (1935896178)
> > > > digikam: ICC file: /home/mrsheep/dipr/srgb.icm ==> Monitor device
> > > > class (1835955314)
> > > > digikam: ICC file: /home/mrsheep/dipr/sRGB.icc ==> Monitor device
> > > > class (1835955314)
> > > > digikam: ICC file: /home/mrsheep/dipr/AdobeRGB1998.icc ==> Monitor
> > > > device class (1835955314)
> > > > digikam: ICC file: /home/mrsheep/dipr/canon6.icm ==> Input device
> > > > class (1935896178)
> > > > digikam: ICC file: /home/mrsheep/dipr/srgb.icm ==> Monitor device
> > > > class (1835955314)
> > > > digikam: ICC file: /home/mrsheep/dipr/sRGB.icc ==> Monitor device
> > > > class (1835955314)
> > > > digikam: ICC file: /home/mrsheep/dipr/AdobeRGB1998.icc ==> Monitor
> > > > device class (1835955314)
> > > > digikam: /media/sde3/bilder/digisvn/HochzeitSilvana2/IMG_3169_2.jpg :
> > > > JPEG file identified
> > > > digikam: Exif color-space tag is sRGB. Using default sRGB ICC
> > > > profile. digikam: Cannot parse EXIF metadata using Exiv2
> > > > digikam: /media/sde3/bilder/digisvn/HochzeitSilvana2/IMG_3169.CR2 :
> > > > RAW file identified
> > > > Warning: Size 5352 of Exif.Canon.0x4002 exceeds 4096 bytes limit. Not
> > > > decoded. digikam: Exif color-space tag is sRGB. Using default sRGB
> > > > ICC profile. digikam: Running dcraw command
> > > > (dcraw,-c,-4,-h,-w,-a,/media/sde3/bilder/digisvn/HochzeitSilvana2/IMG
> > > >_3 16 9. CR2) kio_digikampreview: Running dcraw command
> > > > dcraw -c -e
> > > > '/media/sde3/bilder/digisvn/HochzeitSilvana2/IMG_3169.CR2'
> > > > kio_digikampreview: Running dcraw command
> > > > dcraw -c -e
> > > > '/media/sde3/bilder/digisvn/HochzeitSilvana2/IMG_3169.CR2'
> > > > kio_digikampreview: Use embedded JPEG RAW preview extraction
> > > > kio_digikampreview: Use embedded JPEG RAW preview extraction digikam:
> > > > Parsed PPM header: width 1737 height 1157 rgbmax 65535 Warning: Size
> > > > 5352 of Exif.Canon.0x4002 exceeds 4096 bytes limit. Not decoded.
> > >
> > > there is no error messages, but effectively, there is no message from
> > > the icc color space dialog.
> > >
> > > Please send me the content of [Color Management] section from your
> > > ~./kde/share/config/digikamrc file
> >
> > [Color Management]
> > BPCAlgorithm=true
> > BehaviourICC=false
> > DefaultPath=$HOME/dipr
> > EnableCM=true
> > InProfile=0
> > InProfileFile=$HOME/dipr/canon6.icm
> > ManagedView=false
> > MonitorProfile=1
> > MonitorProfileFile=$HOME/dipr/sRGB.icc
> > ProofProfile=0
> > ProofProfileFile=
> > RenderingIntent=0
> > WorkProfileFile=$HOME/dipr/sRGB.icc
> > WorkSpaceProfile=1
>
> Ok, i understand. remove the sRGB.icc profile from your $HOME/dipr (I
> suspect that it the same than the digikam srgb profile) and select another
> one, like AdobeRGB, and try again. Normally the dialog will appear...
>
> If your RAW file still too black, try an another input profile.

AHHHHH!!!! I'm stupid. I can reproduce the problem here. Sorry. Forget to try 
another input profile in fact.

There is a simple missing condition in icc workflow. I will fix it (:=)))...

Gilles

More information about the Digikam-devel mailing list