[Digikam-devel] Final 0.8.1

[Achim Bohnet]

On Tuesday 17 January 2006 18:44, Gilles Caulier wrote:
> Le Mardi 17 Janvier 2006 18:25, Tom Albers a écrit :
> > Op dinsdag 17 januari 2006 15:48, schreef Gilles Caulier:
> > > Le Lundi 16 Janvier 2006 19:51, Tom Albers a écrit :
> > > > Hi,
> > > >
> > > > The tarball for 0.8.1 is ready, i will announce it wednesday. If you
> > > > are a distro packager and want to be included in the announcement, mail
> > > > me the text before wednesday 17h cet.
> > > >
> > > > http://digikam3rdparty.free.fr/0.8.0/digikam-0.8.1.tar.bz2
> > > >
> > > > Tom
> > >
> > > Compile fine in Mandriva 2006, but...
> > >
> > > kioslave/parse.c file must be removed. This implemntation is obsolete and
> > > out of date. Remember that new implementation is in C++ located
> > > at /libs/dcraw/dcraw_parse.cpp
> > >
> > > You can just remove the source file and changed Makefile.am accordinly.
> >
> > is there a problem leaving it as it is?
> >
> 
> Not sure. It's difficult to check kioslave using valgrind. Normally no because 
> C++ and C Ansi "parse" implementation are completly separed. But parse.c 
> create any static data and methods that increase kioslave object in memory. I 

Memory usage is bad, but does not harm ;)

> think that linking thumb kioslave with both can generated strange effects in 
> memory... I have never tested the code in this case.

If it's not needed we should remove it at least from stable branch.
Mhmm kioslaves run in their own process, so there influence should be
pretty limited.  Anyone noted strange effects?  I'm not sure if it's
worth a new tarball.

Rebuild is fine and thumbnails still working ;)

Question: I found two similar parse.c in digikam source

./digikam/kioslave/parse.c
./digikam/libs/dcraw/parse.c

kioslave/parse.c is an older version.  Can we remove /digikam/libs/dcraw/parse
too?

Achim
> 
> -- 
> Gilles
-- 
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- reddy at lion.austin.ibm.com