[Digikam-devel] hu?

[Caulier Gilles]

Le Lundi 2 Janvier 2006 00:35, Tom Albers a écrit :
> Gilles,
>
> Can you look at this patch? I can not understand why you are splitting a
> qstringlist ;-)
>

mimetypes is a simple QString, not a QStringList. You cannot use iterator on ! 
Have you tried to compile your patch (:=))) ?

My 10 cts €

Gilles

> Have not tested it though.
>
> Tom
> ---------------------
>
> Index: showfoto/showfoto.cpp
> ===================================================================
> --- showfoto/showfoto.cpp       (revision 493241)
> +++ showfoto/showfoto.cpp       (working copy)
> @@ -725,8 +725,7 @@
>              // Else, check if format from file name extension is include
> on file mime type list.
>
>              QString imgExtPattern;
> -            QStringList imgExtList = QStringList::split(" ", mimetypes);
> -            for (QStringList::ConstIterator it = imgExtList.begin() ; it
> != imgExtList.end() ; it++)
> +            for (QStringList::ConstIterator it = mimetypes.begin() ; it !=
> mimetypes.end() ; it++)
>              {
>                  imgExtPattern.append (KImageIO::typeForMime(*it));
>                  imgExtPattern.append (" ");
> Index: utilities/imageeditor/imagewindow.cpp
> ===================================================================
> --- utilities/imageeditor/imagewindow.cpp       (revision 493241)
> +++ utilities/imageeditor/imagewindow.cpp       (working copy)
> @@ -1067,8 +1067,7 @@
>              // Else, check if format from file name extension is include
> on file mime type list.
>
>              QString imgExtPattern;
> -            QStringList imgExtList = QStringList::split(" ", mimetypes);
> -            for (QStringList::ConstIterator it = imgExtList.begin() ; it
> != imgExtList.end() ; it++)
> +            for (QStringList::ConstIterator it = mimetypes.begin() ; it !=
> mimetypes.end() ; it++)
>              {
>                  imgExtPattern.append (KImageIO::typeForMime(*it));
>                  imgExtPattern.append (" ");