[Digikam-devel] ICC Settingspage.

[Tom Albers]

Op vrijdag 10 februari 2006 00:09, schreef F.J.Cruz:
> El Jueves, 9 de Febrero de 2006 23:39, Tom Albers escribió:
> > Hi Paco,
> >
> > I went through the setup page for icc profiles, and I have a few issues,
> > I'm not sure if you are working on them, but I thought I mention them
> > anyway...
> >
> > - When not enabled, it should disable all elements, you can do that
> > simply by disabling the surrounding boxes, it will disable all elements
> > in there.
>
> I think there are not elements enabled whe you disabled color management,
> in any case, I'll try to disable the surrounding boxes.

Hi Paco,

iirc there were some 'info' buttons not disables.

> > - As long as there is no path, hide the ICC Settings part
>
> I don't understand you, what is that  I have to hide?

There is a box which is called 'ICC Settings', which can be disabled without 
path.

> > - When color management is enabled, but no path is set, disable the ok
> > button, you can peak at how it is done in the generalsettings.cpp where
> > it is done for the album library path.
> > - Never close the dialog when something is wrong. But at least you are
> > telling them all settings are lost ;-)
>
> Ok, i'll do it in the same way that generalsettings.cpp
>
> > - the bahviour settings are weird when you are using showfoto.
>
> Have you any better idea? :-D the problem is that showfoto load a lot of
> images at the same time, so the app asks for each one.

No, I mean the text talks about 'image editor', but showfoto is the editor, so 
the setup page is a bit weird when accessed through showfoto.

> > - please read the HACKING file, your coding style is almost opposite to
> > the style guide ;-)
>
> Well, as far I know my only error can be the lenght of code lines (> 80),
> if you can be more explicit.....

No ;-) The length was the main problem...

Toma
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20060212/58208a5a/attachment.sig>