[Digikam-devel] extragear/graphics/digikam

[Marcel Wiesweg]

SVN commit 508653 by mwiesweg:

digikam from trunk: optimize saving, avoid reloading, port to new DImg methods

- replace application-wide override cursor with widget-only wait cursor,
  now that all operations are asynchronous
- split signalChanged from a signal indicating a change in undo/redo status
  (now signalUndoRedoStateChange)
- slots in ImageWindow and Showfoto are split accordingly
- isReadOnly can be retrieved from Canvas/DImgInterface,
  no need to pass it all the way through signals.
  Added appropriate methods
- add extra check to avoid reentrancy in saving. Just for safety.
- what was setModified(false) is now clearUndoManager, setModified(true)
  is now setModified and used extensively inside DImgInterface
- in slotSavingFinished, reorder enabling actions a bit so that the loading call can start
  from a cleanly defined state
- saving is not a modification; do not emit signalModified.
- do not reload image after saving. Added code to saveIsComplete to do what is done
  in the loading slots except for actually loading
- setViewToURL
- not reloading implies that undo history is kept over saving.
  - Formerly, the image did not need to be saved when undo history was empty.
    Now, a point of origin needs to be introduced to the undo manager which identifies the state
    that is identical to the file on disk. 
  - signalUndoRedoStateChange gets a third bool parameter.
  - do not clear undo manager in DImgInterface when saving
- call LoadingCacheInterface::putImage to put the image into cache in ImageWindow and showfoto
- In Canvas and DImgInterface, both save and saveAs were unused and untested. Marked as deprecated,
  renamed saveAsTmpFile to saveAs.
- ported DImgInterface to new putImage and bitBltImage methods of DImg

TODO: I am now hunting the bug that the histogram looks garbled after saving

CCMAIL: digikam-devel at kde.org


 M  +1 -0      showfoto/Makefile.am  
 M  +26 -19    showfoto/showfoto.cpp  
 M  +3 -2      showfoto/showfoto.h  
 M  +41 -31    utilities/imageeditor/canvas/canvas.cpp  
 M  +21 -10    utilities/imageeditor/canvas/canvas.h  
 M  +68 -95    utilities/imageeditor/canvas/dimginterface.cpp  
 M  +10 -6     utilities/imageeditor/canvas/dimginterface.h  
 M  +15 -0     utilities/imageeditor/canvas/undomanager.cpp  
 M  +2 -0      utilities/imageeditor/canvas/undomanager.h  
 M  +47 -29    utilities/imageeditor/editor/editorwindow.cpp  
 M  +2 -6      utilities/imageeditor/editor/editorwindow.h  
 M  +75 -28    utilities/imageeditor/editor/imagewindow.cpp  
 M  +3 -1      utilities/imageeditor/editor/imagewindow.h