[Digikam-devel] [Bug 121646] New: Digikam on PPC has problem identifying JPEG and tries to use dcraw with them

[Achim Bohnet]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=121646         
           Summary: Digikam on PPC has problem identifying JPEG and tries to
                    use dcraw with them
           Product: digikam
           Version: 0.8.1
          Platform: unspecified
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: ach mpe mpg de


Version:           0.8.1 (using KDE 3.5.1, Kubuntu Package 4:3.5.1-0ubuntu3 dapper)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.15-14-686

Hi,
two people on PPC reported problem with jpegs.
Whole thread at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=351931


Fabrice Flore-Thebault:

This version 0.8.1-2 of Digikam is confused by JPEG files produced by a digital
camera : it tries to open them with dcraw, and of course it doesn't work.
(Tests made with images from Canon EOS 300D, Canon EOS 10D, Samsung Digimax A402.)

A contrario, it is still possible to open other JPEG files (produced by sane, 
gimp, convert).

The point is possibly the interpretation of some EXIF information ?

For now, it's only possible to have a look at the thumbnails of these images 
with Digikam... Deactivating the raw image converter plugin doesn't help.

Showfoto has exactly the same problem. 

Other image software like gwenview, gimp work as usual.

I don't know what part of software do the work ? If it is some part of 
digikamimageplugins, then something is wrong with the dependancies between 
these two packages ?

I'm confused, I think I'm note able to help more than copying this output :

Output for Digikam :

~$ digikam
KIPI (loading): KIPI::PluginLoader: plugin KameraKlient is in the ignore list 
for host application
KIPI (loading): KIPI::PluginLoader: Loaded plugin JPEGLossless
KIPI (loading): KIPI::PluginLoader: Loaded plugin CDArchiving
KIPI (loading): KIPI::PluginLoader: Loaded plugin ImagesGallery
KIPI (loading): KIPI::PluginLoader: Loaded plugin SendImages
KIPI (loading): KIPI::PluginLoader: Loaded plugin FlickrExport
KIPI (loading): KIPI::PluginLoader: Loaded plugin Calendar
KIPI (loading): KIPI::PluginLoader: Loaded plugin MPEGEncoder
KIPI (loading): KIPI::PluginLoader: Loaded plugin AcquireImages
KIPI (loading): KIPI::PluginLoader: Loaded plugin GalleryExport
KIPI (loading): KIPI::PluginLoader: Loaded plugin TimeAdjust
KIPI (loading): KIPI::PluginLoader: Loaded plugin FindImages
KIPI (loading): KIPI::PluginLoader: Loaded plugin PrintWizard
KIPI (loading): KIPI::PluginLoader: Loaded plugin WallPaper
KIPI (loading): KIPI::PluginLoader: Loaded plugin SlideShow
KIPI (loading): KIPI::PluginLoader: Loaded plugin BatchProcessImages
digikam: WARNING: Running dcraw command : dcraw -c -2 -w -a -q 0 
'/home/toto/image-300d.jpg'
/home/toto/image-300d.jpg: Cannot decode Canon EOS 300D DIGITAL JPEG images.
digikam: WARNING: Not a raw digital camera image.
digikam: WARNING: Running dcraw command : dcraw -c -2 -w -a -q 0 
'/home/toto/image-10d.jpg'
/home/toto/image-10d.jpg: Cannot decode Canon EOS 10D DIGITAL JPEG images.
digikam: WARNING: Not a raw digital camera image.
digikam: WARNING: Running dcraw command : dcraw -c -2 -w -a -q 0 
'/home/toto/image-sam.jpg'
/home/toto/image-sam.jpg: Cannot decode Samsung Techwin co., Ltd. Digimax A402 
JPEG images.
digikam: WARNING: Not a raw digital camera image.

Output for Showfoto :

~$ showfoto *.jpg
showfoto: WARNING: KIPI::PluginLoader:: createInstanceFromLibrary returned 0 
for ImagePlugin_Core (digikamimageplugin_core) with error number 5
showfoto: WARNING: Running dcraw command : dcraw -c -2 -w -a -q 0 
'/home/toto/image-10d.jpg'
/home/toto/image-10d.jpg: Cannot decode Canon EOS 10D JPEG images.
showfoto: WARNING: Not a raw digital camera image.
showfoto: WARNING: Running dcraw command : dcraw -c -2 -w -a -q 0 
'/home/toto/image-300d.jpg'
/home/toto/image-300d.jpg: Cannot decode Canon EOS 300D DIGITAL JPEG images.
showfoto: WARNING: Not a raw digital camera image.
showfoto: WARNING: Running dcraw command : dcraw -c -2 -w -a -q 0 
'/home/toto/image-sam.jpg'
/home/toto/image-sam.jpg: Cannot decode Samsung Techwin co., Ltd. Digimax A402 
JPEG images.
showfoto: WARNING: Not a raw digital camera image.
...

Anthony Jones:
...
I'm also seeing this bug on PPC (digikam 0.8.1-2). It looks like it
might be an endianness bug in
digikam-0.8.1/digikam/utilities/imageeditor/imlibinterface.cpp:

int ImlibInterface::fileFormat(const QString& filePath)
{
...
    unsigned short jpegID    = 0xD8FF;
...
    if (memcmp(&header, &jpegID, 2) == 0)            // JPEG file ?
    
Comparing the value of an unsigned short with a char array doesn't look
right to me (but then it's been a while since I've programmed in C/C++!)
...

Anthony