[Digikam-devel] [Bug 131743] Comments and tag edit widgets should retain focus when changing image

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=131743         
caulier.gilles kdemail net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles kdemail net  2006-12-22 13:18 -------
SVN commit 615716 by cgilles:

digikam from trunk : Always give the keyboard focus to the Comments text edit widget from Comments & Tags sidebar.
BUG: 131743




 M  +3 -1      NEWS  
 M  +0 -4      digikam/albumwidgetstack.cpp  
 M  +0 -1      digikam/mediaplayerview.cpp  
 M  +3 -0      libs/imageproperties/imagedescedittab.cpp  


--- trunk/extragear/graphics/digikam/NEWS #615715:615716
 @ -407,6 +407,8  @
                  tags (and to 'de'select them).
 243 ==> 132309 : Wish: enhance video support in digikam.
 244 ==> 115153 : Assigns tags not only to selected images with drag and drop.
-245 ==> 
+245 ==> 131743 : Comments and tag edit widgets should retain focus when changing image.
+246 ==> 131632 : Shortcuts for better captioning workflow.
+247 ==> 
 
 ---------------------------------------------------------------------------------------------------- 
--- trunk/extragear/graphics/digikam/digikam/albumwidgetstack.cpp #615715:615716
 @ -144,9 +144,6  @
             imagePreviewWidget()->setImagePath(url.path());
         }
     }
-
-    if (visibleWidget())
-        visibleWidget()->setFocus();
 }
 
 int AlbumWidgetStack::previewMode(void)
 @ -164,7 +161,6  @
         setPreviewItem();
 
     raiseWidget(mode);
-    visibleWidget()->setFocus();
 }
 
 }  // namespace Digikam
--- trunk/extragear/graphics/digikam/digikam/mediaplayerview.cpp #615715:615716
 @ -240,7 +240,6  @
         return;
 
     raiseWidget(mode);
-    visibleWidget()->setFocus();
 }
 
 }  // NameSpace Digikam
--- trunk/extragear/graphics/digikam/libs/imageproperties/imagedescedittab.cpp #615715:615716
 @ -502,6 +502,9  @
     updateDate();
     updateTagsView();
     update();
+
+    // See B.K.O #131632 and #131743 : always give focus to Comments widget.
+    d->commentsEdit->setFocus();
 }
 
 void ImageDescEditTab::updateTagsView()