[Digikam-devel] [Bug 138540] Pictures files are updated (but not modified) when setting new metadatas albeit they are unset

[Fabien]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=138540         
fabien.ubuntu gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |



------- Additional Comments From fabien.ubuntu gmail com  2006-12-12 18:59 -------
Thanks a lot Gilles ! Now, it's getting better :)

But, I'm going to ask you one more thing ;-)
Since the beginning, my concern is to avoid any action to a file if there's no reason to touch it.

Even with your latest modification, the file is still touched even if there's nothing to do on it.
If I'm not wrong (as I don't know C++), it looks like in file digikam/libs/imageproperties/imagedescedittab.cpp there's something that could be changed about :
ImageDescEditTab::applyAllChanges()

You check each setting before setting new metadata, but at the end, in all case, you do a "metadata.applyChanges();".
So, maybe it could be possible to check if there's at least one modification in the different metadatas and then avoid the applyChanges if there's nothing to apply.

I hope I'm not too wrong ;-)