[Digikam-devel] extragear/graphics/digikam/digikam

[Gilles Caulier]

SVN commit 575843 by cgilles:

digikam from trunk : general improvements of icon view reactivity !

This commit is simple : during items selection using mouse draging, it dispatch the current icons selection event only when user have release the left mouse. 

Before this commit the implementation sent an event when a new item have been selected during the selection (under the mouse draging with the left button pressed). I other word, the gui will recieve a lot of events to refresh the sidebar. This way decreased the gui reactivity when metadata/properties sidebar is enable. This problem exist also with the Camera Gui. The problem is more important in this case because the data exanged between the computer and the camera will be important to extract metadata for each camera items.

IMPORTANT : I have tested digiKam Album Gui and Camera Gui with this fix. All work fine but i would to have a right feedback from the team before to valid this change for the next 0.9.0-beta2 planed to september.

Thanks in advance for your reports.

CCMAIL: digikam-devel at kde.org

 M  +1 -3      iconview.cpp  


--- trunk/extragear/graphics/digikam/digikam/iconview.cpp #575842:575843
@@ -963,7 +963,6 @@
             }
 
             blockSignals(false);
-            emit signalSelectionChanged();
         }
         else
         {
@@ -1158,7 +1157,6 @@
 
     if (changed)
     {
-        emit signalSelectionChanged();
         paintRegion.translate(-contentsX(), -contentsY());
         viewport()->repaint(paintRegion);
     }
@@ -1201,6 +1199,7 @@
     {
         if (d->pressedMoved)
         {
+            emit signalSelectionChanged();
             d->pressedMoved = false;
             return;
         }
@@ -1693,7 +1692,6 @@
 
 void IconView::startDrag()
 {
-    
 }
 
 void IconView::ensureItemVisible(IconItem *item)