[Digikam-devel] [PATCH] use a QListBox rather than a set of radio buttons for b&w plugin

[Guillaume Laurent]

On Saturday 29 April 2006 13:35, Gilles Caulier wrote:
> Le Samedi 29 Avril 2006 11:01, Guillaume Laurent a écrit :
> > I'd like to request permission to commit the attached patch (I have svn
> > commit access). It replaces the radio buttons used in the b&w plugin by a
> > QListBox, which makes it much easier to rapidly go through the various
> > possible effects.
>
> Witch avantage provides QListBox instead QRadioButton. Actually, the radio
> buttons group have the focus when the dialog is displayed and you can
> choose the right effetc using up/down keyboard keys.

In general, radio buttons are not meant to represent a list of more than 3 or 
4 choices. When using the mouse, they are harder to aim at than list choices 
(you can click "between" two buttons, or too far to the right, you can't with 
list items).
Also giving focus to the button group doesn't really help, as it doesn't keep 
in sync with mouse clicks : if you click on one of the buttons, and then use 
the arrow keys, the button which gets activated isn't the one next to the one 
you clicked on as you would expect, and you have to use the space bar to 
actually select it.

Finally, another improvement I'd like to make whenever I have the time is to 
let the user create and store his own channel mixer settings. Radio buttons 
wouldn't cope with that.

> > Note that the 'what's this' info is still handled
> > correctly.
>
> What's wrong in the current implementation about this point ?

Nothing, what I meant is that I took care that the 'what's this' info is still 
working with my patch (not completely trivial given that QListBoxItems aren't 
QWidgets).

-- 
Guillaume.
http://www.telegraph-road.org