[Digikam-devel] branches/KDE/3.5/kde-common/admin
Tom Albers
tomalbers at kde.nl
Thu Nov 17 23:30:25 GMT 2005
Op dinsdag 15 november 2005 19:38, schreef Dirk Mueller:
> SVN commit 480611 by mueller:
>
> disable -fvisibility=hidden by default. Too many gcc bugs to
> workaround on popular linux distributions (that break LSB compliance)
Hi Dirk,
I understand almost nothing about visibility things, but I know we have had a
large amount of problems with visibility issues which we seemed to have
tackled the past few months.
I was simply wondering if this change will change anything for us, as we use
this admin dir in our tarball, i'm asking because we have made a rc and now
are on the edge of releasing, do we need a new rc for this change or is it
safe?
gr.
Toma
> M +11 -1 acinclude.m4.in
>
>
> --- branches/KDE/3.5/kde-common/admin/acinclude.m4.in #480610:480611
> @@ -3371,12 +3371,22 @@
> visibility support. Disabling -fvisibility=hidden])
>
> kde_stdc_visibility_patched=no ])
> +
> AC_LANG_RESTORE
>
> kde_have_gcc_visibility=no
> KDE_CHECK_COMPILER_FLAG(fvisibility=hidden,
> [
> kde_have_gcc_visibility=yes
> + dnl the whole toolchain is just a mess, gcc is just too buggy
> + dnl to handle STL with visibility enabled. Lets reconsider
> + dnl when gcc 4.2 is out or when things get fixed in the compiler.
> + dnl Contact mueller at kde.org for details.
> + AC_ARG_ENABLE(gcc-hidden-visibility,
> + AC_HELP_STRING([--enable-gcc-hidden-visibility],[toolchain hidden
> visibility [default=no]]), + [kde_have_gcc_visibility=$enableval],
> + [kde_have_gcc_visibility=no])
> +
> AC_CACHE_CHECK([if Qt is patched for -fvisibility],
> kde_cv_val_qt_gcc_visibility_patched, [
> AC_LANG_SAVE
> @@ -3400,7 +3410,7 @@
> ]
> )
>
> - if test x$kde_stdc_visibility_patched = "xyes" && test
> x$kde_cv_val_qt_gcc_visibility_patched = "xyes"; then + if test
> x$kde_have_gcc_visibility = "xyes" && test x$kde_stdc_visibility_patched =
> "xyes" && test x$kde_cv_val_qt_gcc_visibility_patched = "xyes"; then
> CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
> KDE_CHECK_VISIBILITY_GCC_BUG
> HAVE_GCC_VISIBILITY=1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1930 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20051118/e29db179/attachment.bin>
More information about the Digikam-devel
mailing list