[Digikam-devel] branches/stable/extragear/graphics/digikamimageplugins/common/dialogs

Gilles Caulier caulier.gilles at free.fr
Wed Dec 14 10:22:10 GMT 2005


SVN commit 488400 by cgilles:

Digikam from stable : fix memory leak : KAboutData isn't cleaned automaticly by KDE lib.

CCMAIL: digikam-devel at kde.org

 M  +5 -1      ctrlpaneldialog.cpp  
 M  +2 -0      ctrlpaneldialog.h  


--- branches/stable/extragear/graphics/digikamimageplugins/common/dialogs/ctrlpaneldialog.cpp #488399:488400
@@ -110,6 +110,9 @@
 
     if (m_threadedFilter)
        delete m_threadedFilter;
+
+    if (m_about)
+       delete m_about;       
 }
 
 void CtrlPanelDialog::slotInit()
@@ -131,8 +134,9 @@
 
 void CtrlPanelDialog::setAboutData(KAboutData *about)
 {
+    m_about = about;
     QPushButton *helpButton = actionButton( Help );
-    KHelpMenu* helpMenu = new KHelpMenu(this, about, false);
+    KHelpMenu* helpMenu = new KHelpMenu(this, m_about, false);
     helpMenu->menu()->removeItemAt(0);
     helpMenu->menu()->insertItem(i18n("Plugin Handbook"), this, SLOT(slotHelp()), 0, -1, 0);
     helpButton->setPopup( helpMenu->menu() );
--- branches/stable/extragear/graphics/digikamimageplugins/common/dialogs/ctrlpaneldialog.h #488399:488400
@@ -84,6 +84,8 @@
     QTimer          *m_timer;
     
     QString          m_name;
+
+    KAboutData      *m_about;
     
     bool             m_tryAction;
     



More information about the Digikam-devel mailing list