[Digikam-devel] [Bug 110514] New: Enhanced selection, refactored histogram

[gsasha at cs.technion.ac.il]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=110514         
           Summary: Enhanced selection, refactored histogram
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Image Editor
        AssignedTo: digikam-devel kde org
        ReportedBy: gsasha cs technion ac il


Version:            (using KDE KDE 3.4.2)
Installed from:    Compiled From Sources
OS:                Linux

I have done several enhancements to the Image Editor. Changes include:

1. Enhanced selection, with sane behavior of moving, resizing, etc. The implementation sits outside of the Canvas, and is reusable.
2. Refactored out the Histogram. Now the rendering sits in one class, and moving - in another (I will probably reuse Selector's code for this if resizing of the Histogram is required). As a result, the code is much simpler and more straightforward.
3. Removed the separate thread used for computing the Histogram. It doesn't look like it was improving the responsibility a lot, but made the whole thing more complicated. (receiving a CustomEvent as notification is way too ugly to my understanding).
4. Added a new Histogram mode, RGB (currently it's what is shown when Alpha is selected.
5. Changed the rendering of Histogram, no flicker now.

The [current version of] patch can be found at <a href="http://www.cs.technion.ac.il/~gsasha/selectorv4.diff">http://www.cs.technion.ac.il/~gsasha/selectorv4.diff</a>.
I will also provide the diff as an attachment here.