About the Commit Digest

[Vladislav Blanton]

Danny, you are awesome for being available and present years into the
project, and (a year?) after choosing to let the community take it over.

V

On Fri, Oct 5, 2012 at 1:27 PM, Danny Allen <me at dannya.com> wrote:

> Hi Aleix!
>
> Answers below...
>
> > Classify Area:
> > - commits in kdelibs are set in the KDE Base area. That sounds odd,
> specially considering that we want the KDE Frameworks to be a thing.
>
> This is a legacy thing (Digest has been running since KDE was in CVS!), I
> haven't made changes to classifications for consistency with historical
> issues, but I'm not against it on principle.
>
> > - In the classify tab, we have an option for mouse or keyboard.
> > Keyboard sounds great but I don't know what to do with it. Where can I
> find the key bindings?
>
> First click the keyboard option in the bottom bar, then on the left there
> are two buttons with the numbers for each box.
>
> > - We don't have a "Documentation" type? Should those be marked as Other?
> Also Accessibility or usability fixes could be put together in a different
> type, since it's something nice to tell the world about.
>
> Indeed, I agree - maybe new classifications is in order...
>
> > - Now I've been reviewing for a while (~40 commits) and it said "save
> unsuccessful". :( why?
>
> Only thing I can think of is you took a long time doing this and were
> logged out? Then the AJAX call to save would fail...
> What browser?
>
> > - Should we really show things that aren't master? These should be shown
> when the branch has been merged, no?
> > - Shouldn't we have a "dude what are you doing!" button? I just saw this
> in:
> > "Tidy up white space, indentation and comments in the Brain class."
> > Is this really commit digest material?
>
> You're right, that should be rejected - while there isn't a button in the
> Classify interface to reject commits, there *is* in the Editor interface
> (the next stage) for each specific Digest..
>
> > Review Area:
> > - I can't jump over an item? am I forced to say yes/no to every commit?
>
> At the moment in the Review interface, yes (in the Classify interface any
> you leave blank remain) - haven't really had an issue with this before,
> especially as I use the keyboard interface in review and am pretty quick
> going through them?
>
> > - Wouldn't it make sense to be able to put some commits together somehow?
>
> Maybe, especially with Git, wasn't such an issue in the past...
>
> > - When merging we don't get a list of what's been merged, it would be
> helpful for considering whether the commit is interesting or not.
> > Merging a branch is something very important from my PoV (or maybe it
> can be too important and blog post material, don't know).
> > - Maybe SILENT should be filtered out?
>
> Yeah, I meant to make this configurable! (I'm starting to sound pathetic
> now ;))
>
> > In general:
> > - would it be possible to expose an API for this? it looks like a great
> way of spending your time on the subway.
>
> I had quite a few plans, then real life got in the way!
> Stuff like this are things that appeal to me a lot though, shame there
> doesn't seem to be many people with PHP experience in the KDE community as
> I made Enzyme open source but have never had any contributions in the code!
> I'd like to force myself to get back in development on it though if I can
> find some time, I know some different groups are interested in the Enzyme
> platform and I want to support them in this.
>
> > In any case, please understand I'm a n00b in this. If you're not the
> people I should be contacting, please redirect me, :)
>
> Thanks for your considered email, good to have you onboard!
>
> Do join our mailing list! https://mail.kde.org/mailman/listinfo/digest
>
> Many thanks,
> Danny
>
> _______________________________________________
> Digest mailing list
> Digest at kde.org
> https://mail.kde.org/mailman/listinfo/digest
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digest/attachments/20121011/8dad2bea/attachment-0001.html>