Hi, new contributor here and two small bugs :)

[Vladislav Blanton]

Hello Gaël and Welcome!

I am not sure if you saw my previous welcome email to you, which I sent to
the list, but once again, welcome!

Great work hammering away at the excess commits. So that you know, in
general we do not classify our own commits that we reviewed, unless there is
a time crunch involved. Especially since you just started doing this, it is
good if we can double check the commits you chose before they are classified
(and thus part of the digest).

As an example:
----------------
Commit *1e16b68...* by Frank Reininghaus (freininghaus)
[kde-baseapps] /src
 Add function KItemListSelectionManager::isSelected(int index)

This function is used in KItemListView::updateWidgetProperties()
to find out if an item is selected in a more efficient way.
The new function is tested in KItemListSelectionManagerTest.
I've factored out some code from
KItemListSelectionManagerTest::testChangeSelection() to a new
member to simplify the test.
----------------
This commit is not a very interesting feature, bug fix, or optimization.

thanks for the good work!

Vlad



On Tue, Oct 4, 2011 at 9:23 AM, Gaël Beaudoin <gaboo at gaboo.org> wrote:

> Hi,
>
> I've just started contributing to the commit digest using enzyme. After
> reading it since the first edition and also reading commits  and various kde
> mailing list, I've finally jumped in to help.
>
> The tool is easy to use and fast so that reviewing does not takes too much
> time :)
>
> I still have two small bugs :
> * I often am not able to save the first commit in the review list. For
> instance, there is only one left now, that i'd like to approve and classify,
> but when saving I get "save unsuccessful" message. When in a batch of
> several commits, the state is not saved either.
> * in the classify section, I'm not able to delete a commit. I've just tried
> again. I click the red cross, click ok in the dialog and nothing happens,
> even if I click save afterwards.
>
> Those two bugs happen with both firefox 7 and chrome 13 btw.
>
> I hope I'm not complaining too much already :D
>
> Have a nice day!
> Gaël
>
>
>
> _______________________________________________
> Digest mailing list
> Digest at kde.org
> https://mail.kde.org/mailman/listinfo/digest
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digest/attachments/20111004/a174880e/attachment.html>