removing included commits during classfying?

Danny Allen danny at commit-digest.org
Mon Dec 13 12:21:09 CET 2010


Hi all,
Currently, commits can be removed from the final Digest by editors in the Digest management section.
I'll think about ways of improving the situation / making this more clear (basically, there are very few "destructive" actions in the system).

As regards to the other question, things like compile fixes, unit tests, etc are pretty much always not worthy of inclusion (I delete them from the final Digest) - the only exception is a message like "finally all the unit tests pass after that huge refactoring..."

Danny


----- Original Message -----
From: "Roger Pixley" <skreech2 at gmail.com>
To: "Alexander van Loon" <a.vanloon at alexandervanloon.nl>
Cc: digest at kde.org
Sent: Monday, 13 December, 2010 1:51:44 AM
Subject: Re: removing included commits during classfying?


Hmm Not sure. anyone has successfully removed a classification before? 


On Sat, Dec 11, 2010 at 6:44 AM, Alexander van Loon < a.vanloon at alexandervanloon.nl > wrote: 


I’m classifying commits right now, and noticed this commit: 

Commit 1201540 by Andreas Hartmetz (ahartmetz) 
/trunk/KDE/kdebase/workspace/kcontrol/keyboard/tests/CMakeLists.txt 
link with gold 
Reviewed by echidna 

I think this is a unit test – note the ‘tests’ directory – and the 
review guidelines recommend that unit tests be excluded. Besides that 
the description is very cryptic, the commit details don’t shed much 
light on it either. Is there a way to remove commits during 
classification, if it looks like the reviewer made a mistake? 

Greetings, 
Alexander van Loon 

_______________________________________________ 
Digest mailing list 
Digest at kde.org 
https://mail.kde.org/mailman/listinfo/digest 


_______________________________________________
Digest mailing list
Digest at kde.org
https://mail.kde.org/mailman/listinfo/digest


More information about the Digest mailing list