Review Request 123603: Bug 345804 - Port away from QString(char*)

Andrea Scarpino scarpino at kde.org
Mon May 18 20:19:24 UTC 2015 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123603/#review80605
-----------------------------------------------------------


Great! Thank you

- Andrea Scarpino


On May 18, 2015, 8:28 p.m., Gilbert Assaf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123603/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 8:28 p.m.)
> 
> 
> Review request for Choqok.
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> Bug 345804 - Port away from QString(char*)
> 
> 
> Diffs
> -----
> 
>   choqok/config/accounts/accountswidget.cpp 7cf0dfe280d4a4ca8885b8074da431e46a1309af 
>   choqok/config/appearance/appearanceconfig.cpp 4936dcc8e522a0d1633138f59477a089ebdeef66 
>   choqok/config/behavior/behaviorconfig.cpp fddaf252039fb10935ad63b28cb2d381ca7b7781 
>   choqok/config/behavior/behaviorconfig_shorten.cpp fb84806a2c9347698619300bfdc0a0f3b08e4049 
>   choqok/config/plugins/choqokpluginconfig.cpp e93d76ed17e090eb47645d4d3639de70efaa06c5 
>   choqok/main.cpp f6ed1bfa467e7ddf4c86fc99379831914ece2db0 
>   choqok/mainwindow.cpp 0c74332d39862ced66d6c8b52fe8746f865840e5 
>   choqok/systrayicon.cpp 66390f56123c2e25f160d99eff143a6b4afb0212 
>   helperlibs/twitterapihelper/twitterapiaccount.cpp 9991b1de27a231abfa916023a828e352e1460130 
>   helperlibs/twitterapihelper/twitterapidmessagedialog.cpp 66ed33f1a7d75677e1f6ef9df6ea37064230dc5c 
>   helperlibs/twitterapihelper/twitterapimicroblog.cpp f5b3a24f0ac72f346d5074848e10f70d0e2b21a2 
>   helperlibs/twitterapihelper/twitterapimicroblogwidget.cpp b319bc60cd2468ce8bfcb603ece07b349fba9641 
>   helperlibs/twitterapihelper/twitterapipostwidget.cpp 54d0a898ad34b0f0ac565afe9468be65267a0a8a 
>   helperlibs/twitterapihelper/twitterapisearch.cpp c9b04b51d1aa29f4d96e239fc3a69db06a895e1b 
>   helperlibs/twitterapihelper/twitterapisearchtimelinewidget.cpp 8e89e5752071989c1cbf6b8e201c5a18996c7f32 
>   helperlibs/twitterapihelper/twitterapishowthread.cpp eb8cdc0378442c29921d4f6d3f1fb1f41768ece8 
>   helperlibs/twitterapihelper/twitterapitextedit.cpp 60e3674a60ed825e247f09bda3536d3360c5299d 
>   helperlibs/twitterapihelper/twitterapitimelinewidget.cpp 891c3369330c214929ba8accacf9db1b34fefad4 
>   helperlibs/twitterapihelper/twitterapiwhoiswidget.cpp d295fd28584e4be4364a9a2316d07f6df14369e8 
>   libchoqok/accountmanager.cpp 08daae3c4fcaf769c2153d9006d987c605b5afbd 
>   libchoqok/choqoktools.cpp f31d91571d390610352f9f052d67838e438702d1 
>   libchoqok/dbushandler.cpp 2e9c2930b215812589666f986c56c3468af356dd 
>   libchoqok/mediamanager.cpp fa092d1933f5407296e0b895bb2899bcafb37dbb 
>   libchoqok/notifymanager.cpp 77826d941ba3e707784e5f97ab57ac8d0c8c7b15 
>   libchoqok/passwordmanager.cpp 442433e5b1bacca4673cb4941d0b6b40a1f72ad7 
>   libchoqok/pluginmanager.cpp 0d3b20b6f83a43662ae11866163f970f077259e4 
>   libchoqok/shortenmanager.cpp f6c4694148464ecf5f0f3b65147ce0eb1de2e55e 
>   libchoqok/ui/choqoktabbar.cpp 8b4690d053d2123c8a66bb162671ec1e5344721e 
>   libchoqok/ui/choqoktextedit.cpp 457d8f002fb9569d3f2beb779188ef9312ca6880 
>   libchoqok/ui/composerwidget.cpp 58ca5e089ecaf8a4e9223ed7ce6fb6aab6039904 
>   libchoqok/ui/microblogwidget.cpp 0bdec4c18ecb1559515b2bb95c6c39750b9bcd21 
>   libchoqok/ui/postwidget.cpp 87e5a1952d8a95186380323c49d4298f95da3e48 
>   libchoqok/ui/quickpost.cpp 2f11b0235acee9f42cffcd2442b5ea993328a597 
>   libchoqok/ui/timelinewidget.cpp 8ad5718dbcdce781e498f218c3177329f9f77633 
>   libchoqok/ui/uploadmediadialog.cpp 4743bc13049b6040ba88c9c8a7cdb67084054448 
>   libchoqok/urlutils.cpp 48d7c11e7aefac6140e9cc543890830a969eff84 
>   microblogs/laconica/laconicaaccount.cpp bc736f5083e69db7cd070395c7ad72b72df4917d 
>   microblogs/laconica/laconicacomposerwidget.cpp 7e2273d455fe5473d2e82fd75e5decfc0909a00a 
>   microblogs/laconica/laconicaeditaccount.cpp 7ae40554ff284a026e6e75bc94d86bc678a4c733 
>   microblogs/laconica/laconicamicroblog.cpp 8962ad6349e6c01e81eb98d87201ccfc68b49463 
>   microblogs/laconica/laconicapostwidget.cpp aad527ed809c53973484c087dd9c55f0062c197a 
>   microblogs/laconica/laconicasearch.cpp 8293145c7856f70b40042c6216f20168c152a074 
>   microblogs/pumpio/pumpioaccount.cpp 8e5e8872741d4818c200ccec411a81191d19c265 
>   microblogs/pumpio/pumpiocomposerwidget.cpp f6f8a827e11274e7e589e8bd6c789e0efed3ae34 
>   microblogs/pumpio/pumpioeditaccountwidget.cpp f545479b1936d852c204bf717892e5f9ef005606 
>   microblogs/pumpio/pumpiomessagedialog.cpp 66f1b609e9192fc3d74b3c71482f55ef0e15544f 
>   microblogs/twitter/twitteraccount.cpp ad8c61800f55bf29e5598a765425c1ba1f0a0117 
>   microblogs/twitter/twittercomposerwidget.cpp 8f22fc8160effdd7dd87cecd81993b72f121ad5a 
>   microblogs/twitter/twittereditaccount.cpp 41cce51de0fb983741ec367ec4774534437fd26c 
>   microblogs/twitter/twitterlistdialog.cpp 04279d62acb4d0c4fb8867c4a603bb58c587e707 
>   microblogs/twitter/twittermicroblog.cpp 366fc495d40a25a0943a976c8aa894c9716da798 
>   microblogs/twitter/twitterpostwidget.cpp 6c7aaf48bb731d31e36c3d2a99745bc868cc7c52 
>   microblogs/twitter/twittersearch.cpp d95be43c4c94883f1e35da23ae76b9a6539ba553 
>   microblogs/twitter/twittertimelinewidget.cpp 7759da6ea8f91fe702a1cb51cc2d4d2dfdb5bdba 
>   plugins/betternotify/dummynotification.cpp 9c2d8d67c4e2ca7dbf520e5e5b8f4bc9a52938f0 
>   plugins/betternotify/notification.cpp 5c7a357dd820419ea88e2f6aa41d338128c634f2 
>   plugins/betternotify/notify.cpp 0337484ce01b7edad83bd380609cb89038743786 
>   plugins/betternotify/notifyconfig.cpp 35ee79ac7b02135b23b28cb8c40cfc065ffdd913 
>   plugins/betternotify/notifysettings.h fe11222af0caff2a62067c37687f4e3a64bbfa20 
>   plugins/filter/filtermanager.cpp 20ca72fc72543d57cecfcdb27e5928e1041b1454 
>   plugins/imagepreview/imagepreview.cpp c66cc582b01e24bf2259bb084e69a74ae1ac07de 
>   plugins/imstatus/imqdbus.cpp 61c40b56a46cb3eb4c95e6d81ffc412d0db97075 
>   plugins/imstatus/imstatus.cpp 4021db1f5ee4b95f7aa13905c4091cf52d29919d 
>   plugins/imstatus/imstatusconfig.cpp 2506c857ccc714efdc3ab2866321884e4030a9f8 
>   plugins/konqueror/konqchoqok.cpp bf745992f155aa7a8094eef0473154886ab47d0f 
>   plugins/longurl/longurl.cpp a1981d5373218a8190b05c696dbb317304ee42f3 
>   plugins/nowlistening/mpris.h a376ae196a302fe66902baa44a6a8d1157dc7b53 
>   plugins/nowlistening/mpris.cpp b0c2319c0d5dd6372d1e55f1020d88184ef2a92a 
>   plugins/nowlistening/nowlistening.cpp 7f2d9dd142dfe8189a847a3d704adf5927929269 
>   plugins/nowlistening/nowlisteningconfig.cpp 3196859bdd50f25ab489e236d94d1714bc7574e4 
>   plugins/quickfilter/quickfilter.cpp 3ecb6b378ea2eadca953f15ab515f9a784977e65 
>   plugins/searchaction/searchaction.cpp cf9fae5d75e61f85cc93183db52663f899e6e564 
>   plugins/shorteners/bit_ly/bit_ly.cpp 905f61afb01b07d420511b963f0313402110387f 
>   plugins/shorteners/bit_ly/bit_ly_config.cpp 1033d7b72e1a9841749a4660eaa18f66f56b78ac 
>   plugins/shorteners/goo_gl/goo_gl.cpp 8ce47bc7690dfc1909960473df8a7d2da8aaadda 
>   plugins/shorteners/is_gd/is_gd.cpp 799de4aae4f2224d2e6937e13716a3f6f3292200 
>   plugins/shorteners/is_gd/is_gd_config.cpp d99bf78eb393947b2fd277b3ad2cef598e260835 
>   plugins/shorteners/tighturl/tighturl.cpp acde000165404353ae0a93729a43f49518fa5d7b 
>   plugins/shorteners/tinyarro_ws/tinyarro_ws.cpp e88f4998d2308de1862bb178d86050f17404f1c0 
>   plugins/shorteners/tinyarro_ws/tinyarro_ws_config.cpp 77eb9c7941fa8bd319cfd409bfedd121f6a72402 
>   plugins/shorteners/ur1_ca/ur1_ca.cpp 098242765a6d919b60ed9fcb68010009c5f6d27c 
>   plugins/shorteners/ur_ly/ur_ly.cpp a0eaa125ed63041c3324c5e7dd45b00594a9005c 
>   plugins/shorteners/yourls/yourls.cpp b22d3cecf0a504fbbb2f56c79652d6925be15291 
>   plugins/shorteners/yourls/yourlsconfig.cpp ce837b3cef47fbe45be754fb20fcfda74ef72718 
>   plugins/uploaders/flickr/flickr.cpp 78ead6020e4a6bff7b2b61dfedffaa94483260e9 
>   plugins/uploaders/flickr/flickrconfig.cpp 4cb34f12daa5144a992f7e95ad50161f4266d390 
>   plugins/uploaders/imageshack/imageshack.cpp c414cc63441b2ebbc945f90690914a858d75928f 
>   plugins/uploaders/mobypicture/mobypicture.cpp 5b8d0c1c9e3f5e2ea4b02c0586ed041ae8b4b049 
>   plugins/uploaders/mobypicture/mobypictureconfig.cpp 8fced09dbfadb18f6ce2e63aea356ef682bf8cdc 
>   plugins/uploaders/posterous/posterous.cpp ddd867362a37d8a45eb4be85caac9c5f3e52ec84 
>   plugins/uploaders/posterous/posterousconfig.cpp 9a08320a9e77fe00ca61c3377acfd94f4cefe728 
>   plugins/uploaders/twitgoo/twitgoo.cpp 4c8d2d46f023631cba2ad90e1b1bff74b14a5b1c 
>   plugins/uploaders/twitgoo/twitgooconfig.cpp b4e0205c78fe80cfa584b4854dbb61557cd10d2f 
>   plugins/videopreview/videopreview.cpp c50ae61fde3e38319f620f37a949b9b63f6e446e 
> 
> Diff: https://git.reviewboard.kde.org/r/123603/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20150518/1522ac1b/attachment-0001.html>

More information about the Choqok-devel mailing list