Review Request 123603: Bug 345804 - Port away from QString(char*)

[Gilbert Assaf]

> On May 4, 2015, 5:57 a.m., Andrea Scarpino wrote:
> > Hi, I suppose you meant bug 345804 "Port away from QString(char)" instead, correct?
> > 
> > Just to be clear:
> > - bug 345804 requires choqok to build without line 16 in our current CMakeLists.txt
> > - bug 345805 requires choqok to build without line 18 in our current CMakeLists.txt

Yes you are correct. I somehow copied the wrong text into the summary... :-/


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123603/#review79826
-----------------------------------------------------------


On May 4, 2015, 7:07 p.m., Gilbert Assaf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123603/
> -----------------------------------------------------------
> 
> (Updated May 4, 2015, 7:07 p.m.)
> 
> 
> Review request for Choqok.
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> Bug 345804 - Port away from QString(char*)
> 
> 
> Diffs
> -----
> 
>   libchoqok/accountmanager.cpp 08daae3c4fcaf769c2153d9006d987c605b5afbd 
>   libchoqok/passwordmanager.cpp 442433e5b1bacca4673cb4941d0b6b40a1f72ad7 
>   libchoqok/pluginmanager.cpp 0d3b20b6f83a43662ae11866163f970f077259e4 
>   libchoqok/shortenmanager.cpp f6c4694148464ecf5f0f3b65147ce0eb1de2e55e 
> 
> Diff: https://git.reviewboard.kde.org/r/123603/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20150508/d64e6032/attachment.html>