Review Request 122567: Sort/cleanup includes

Mehrdad Momeny mehrdad.momeny at gmail.com
Sun Feb 15 02:24:59 UTC 2015 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122567/#review76037
-----------------------------------------------------------

Ship it!


Ship It!

- Mehrdad Momeny


On Feb. 14, 2015, 10:33 a.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122567/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2015, 10:33 a.m.)
> 
> 
> Review request for Choqok.
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> - Drop Qt/KDE prefixes (this helps with the Qt5/KF5 transition)
> - Do not use <filename> for project headers
> - Sort headers
> - Use camelcase headers
> 
> 
> Diffs
> -----
> 
>   libchoqok/pluginmanager.h 8798f30 
>   microblogs/pumpio/pumpioeditaccountwidget.h e99ff76 
>   microblogs/pumpio/pumpiocomposerwidget.cpp 7e4bc8b 
>   microblogs/ocs/ocsmicroblog.cpp 3930f7f 
>   microblogs/pumpio/pumpioaccount.h 5377f01 
>   microblogs/ocs/ocsmicroblog.h 87741b3 
>   microblogs/ocs/ocsaccount.cpp 2d6e064 
>   microblogs/ocs/ocsaccount.h 2b579bd 
>   microblogs/laconica/laconicasearch.cpp 4b1c9c9 
>   plugins/betternotify/notifysettings.h 106066e 
>   plugins/betternotify/notifysettings.cpp 84b08a3 
>   plugins/filter/addeditfilter.h 87e031b 
>   plugins/filter/addeditfilter.cpp 913c854 
>   plugins/filter/configurefilters.h 0fb6c64 
>   plugins/filter/configurefilters.cpp c30a84d 
>   plugins/filter/filter.cpp 2ce9d94 
>   plugins/filter/filtermanager.h a50172d 
>   plugins/filter/filtermanager.cpp bb4faee 
>   plugins/filter/filtersettings.h 71729f5 
>   plugins/filter/filtersettings.cpp fd0599d 
>   plugins/imagepreview/imagepreview.h 2e42c4c 
>   plugins/imagepreview/imagepreview.cpp 3bd0efc 
>   plugins/imstatus/imqdbus.h 890184a 
>   plugins/imstatus/imqdbus.cpp 7c78b34 
>   plugins/imstatus/imstatus.h 7717814 
>   plugins/imstatus/imstatus.cpp 78d3ed9 
>   plugins/imstatus/imstatusconfig.h 7ed9b7f 
>   plugins/imstatus/imstatusconfig.cpp 9e35da8 
>   plugins/konqueror/konqchoqok.h 45a3fdf 
>   plugins/konqueror/konqchoqok.cpp a995292 
>   plugins/longurl/longurl.h 6f22dde 
>   plugins/longurl/longurl.cpp 759df29 
>   plugins/nowlistening/mpris.cpp 5774ccc 
>   plugins/nowlistening/nowlistening.h 89f4cb0 
>   plugins/nowlistening/nowlistening.cpp 82d1a3d 
>   plugins/nowlistening/nowlisteningconfig.h 93201fa 
>   plugins/nowlistening/nowlisteningconfig.cpp fe9d0de 
>   plugins/quickfilter/quickfilter.h 5c99f9c 
>   plugins/quickfilter/quickfilter.cpp 2b8b749 
>   plugins/searchaction/searchaction.h 9d1e51c 
>   plugins/searchaction/searchaction.cpp c9479e4 
>   plugins/shorteners/bit_ly/bit_ly.h 0f60804 
>   plugins/shorteners/bit_ly/bit_ly.cpp 55c64c4 
>   plugins/shorteners/bit_ly/bit_ly_config.h 6c77558 
>   plugins/shorteners/bit_ly/bit_ly_config.cpp 4b44e0c 
>   plugins/shorteners/goo_gl/goo_gl.h 9eafa6f 
>   plugins/shorteners/goo_gl/goo_gl.cpp 1007808 
>   plugins/shorteners/is_gd/is_gd.h d14a850 
>   plugins/shorteners/is_gd/is_gd.cpp d9eac60 
>   plugins/shorteners/is_gd/is_gd_config.h 1fbe06b 
>   plugins/shorteners/is_gd/is_gd_config.cpp 86c9578 
>   plugins/shorteners/tighturl/tighturl.h 1069eb8 
>   plugins/shorteners/tighturl/tighturl.cpp 9b4ae61 
>   plugins/shorteners/tinyarro_ws/tinyarro_ws.h 8bf8d10 
>   plugins/shorteners/tinyarro_ws/tinyarro_ws.cpp 34c5437 
>   plugins/shorteners/tinyarro_ws/tinyarro_ws_config.h d636739 
>   plugins/shorteners/tinyarro_ws/tinyarro_ws_config.cpp e26de24 
>   plugins/shorteners/ur1_ca/ur1_ca.h 125e951 
>   plugins/shorteners/ur1_ca/ur1_ca.cpp 8aa243e 
>   plugins/shorteners/ur_ly/ur_ly.h 2974a63 
>   plugins/shorteners/ur_ly/ur_ly.cpp 6f01e2a 
>   plugins/shorteners/yourls/yourls.h b3e7e6b 
>   plugins/shorteners/yourls/yourls.cpp 7bbeddf 
>   plugins/shorteners/yourls/yourlsconfig.h 5d4b7dd 
>   plugins/shorteners/yourls/yourlsconfig.cpp dd8655f 
>   plugins/uploaders/flickr/flickr.h 6fd3d64 
>   plugins/uploaders/flickr/flickr.cpp f0312e3 
>   plugins/uploaders/flickr/flickrconfig.h 1e2a78f 
>   plugins/uploaders/flickr/flickrconfig.cpp 9f0d920 
>   plugins/uploaders/imageshack/imageshack.h 0646551 
>   plugins/uploaders/imageshack/imageshack.cpp 22cde14 
>   plugins/uploaders/mobypicture/mobypicture.h 6dd7023 
>   plugins/uploaders/mobypicture/mobypicture.cpp be33f1d 
>   plugins/uploaders/mobypicture/mobypictureconfig.h 340afd7 
>   plugins/uploaders/mobypicture/mobypictureconfig.cpp de28529 
>   plugins/uploaders/posterous/posterous.h 2f55b8a 
>   plugins/uploaders/posterous/posterous.cpp bb4917e 
>   plugins/uploaders/posterous/posterousconfig.h 49b8180 
>   plugins/uploaders/posterous/posterousconfig.cpp 309f549 
>   plugins/uploaders/twitgoo/twitgoo.h e1b1fc5 
>   plugins/uploaders/twitgoo/twitgoo.cpp 65766e9 
>   plugins/uploaders/twitgoo/twitgooconfig.h ca5aefa 
>   plugins/uploaders/twitgoo/twitgooconfig.cpp a7bf340 
>   plugins/uploaders/twitpic/twitpic.h d63e630 
>   plugins/uploaders/twitpic/twitpic.cpp a91c5ef 
>   plugins/uploaders/twitpic/twitpicconfig.h 18c0ae1 
>   plugins/uploaders/twitpic/twitpicconfig.cpp d788b38 
>   plugins/videopreview/videopreview.h 58ed2aa 
>   plugins/videopreview/videopreview.cpp 952fa04 
>   microblogs/pumpio/pumpioeditaccountwidget.cpp 348cff0 
>   microblogs/twitter/twitteraccount.h a11ad9d 
>   microblogs/twitter/twitteraccount.cpp 4160682 
>   microblogs/twitter/twittercomposerwidget.h 0b0530d 
>   microblogs/twitter/twittercomposerwidget.cpp 3949b4b 
>   microblogs/twitter/twittereditaccount.h 04b15b0 
>   microblogs/twitter/twittereditaccount.cpp 05f3ca6 
>   microblogs/twitter/twitterlistdialog.h 6f0e3ff 
>   microblogs/twitter/twitterlistdialog.cpp ba5208b 
>   microblogs/twitter/twittermicroblog.h cac2a16 
>   microblogs/twitter/twittermicroblog.cpp d646676 
>   microblogs/twitter/twitterpostwidget.h af85c4d 
>   microblogs/twitter/twitterpostwidget.cpp a07b856 
>   microblogs/twitter/twittersearch.cpp da85565 
>   plugins/betternotify/dummynotification.h 69de64a 
>   plugins/betternotify/dummynotification.cpp 587d117 
>   plugins/betternotify/mytextbrowser.cpp eee0493 
>   plugins/betternotify/notification.h b5186be 
>   plugins/betternotify/notification.cpp 816ad9a 
>   plugins/betternotify/notify.h 17f6e2f 
>   plugins/betternotify/notify.cpp 5e821ba 
>   plugins/betternotify/notifyconfig.h 1986946 
>   plugins/betternotify/notifyconfig.cpp 76adaa6 
>   libchoqok/urlutils.h e0a141c 
>   microblogs/laconica/laconicaaccount.h 679ebc3 
>   microblogs/laconica/laconicaaccount.cpp 9a51d90 
>   microblogs/laconica/laconicacomposerwidget.h 7edaa6b 
>   microblogs/laconica/laconicacomposerwidget.cpp c0a91b3 
>   microblogs/laconica/laconicaconversationtimelinewidget.h c6fd593 
>   microblogs/laconica/laconicaconversationtimelinewidget.cpp d8c4a4d 
>   microblogs/laconica/laconicaeditaccount.h ef06d2e 
>   microblogs/laconica/laconicaeditaccount.cpp 2f36019 
>   microblogs/laconica/laconicamicroblog.h e8d6642 
>   microblogs/laconica/laconicamicroblog.cpp 607c2b2 
>   microblogs/laconica/laconicapostwidget.h ace2713 
>   microblogs/laconica/laconicapostwidget.cpp 3d4c31b 
>   libchoqok/ui/choqoktextedit.h 50c4d59 
>   libchoqok/ui/choqoktextedit.cpp 50bfe9b 
>   libchoqok/ui/composerwidget.h 217b9ce 
>   libchoqok/ui/composerwidget.cpp b53853a 
>   libchoqok/ui/editaccountwidget.h a399b4d 
>   libchoqok/ui/microblogwidget.h ef83bf8 
>   libchoqok/ui/microblogwidget.cpp 35df8f0 
>   libchoqok/ui/postwidget.h 4db8dcb 
>   libchoqok/ui/postwidget.cpp c03ad7a 
>   libchoqok/ui/quickpost.h 64c2142 
>   libchoqok/ui/quickpost.cpp 83d7440 
>   libchoqok/ui/textbrowser.h 54707af 
>   libchoqok/ui/textbrowser.cpp 756f1a5 
>   libchoqok/ui/timelinewidget.h 305708e 
>   libchoqok/ui/timelinewidget.cpp a3442a4 
>   libchoqok/ui/uploadmediadialog.h d1873c7 
>   libchoqok/ui/uploadmediadialog.cpp ad0f542 
>   libchoqok/uploader.h c431d6a 
>   libchoqok/pluginmanager.cpp 7b4c4fb 
>   libchoqok/shortener.h 95ee143 
>   libchoqok/shortener.cpp 0816fd0 
>   libchoqok/shortenmanager.h a96ea69 
>   libchoqok/shortenmanager.cpp ae3b6f6 
>   libchoqok/ui/choqokmainwindow.h 8a109e0 
>   libchoqok/ui/choqokmainwindow.cpp fd2817b 
>   libchoqok/ui/choqoktabbar.h 1c79aa8 
>   libchoqok/ui/choqoktabbar.cpp 97dca7f 
>   helperlibs/twitterapihelper/twitterapipostwidget.cpp 03ed3b0 
>   choqok/choqokapplication.h c8a687e 
>   choqok/choqokapplication.cpp 09b0292 
>   choqok/config/accounts/accountswidget.h 8099294 
>   choqok/config/accounts/accountswidget.cpp b69d7f1 
>   choqok/config/accounts/addaccountdialog.h 461e705 
>   choqok/config/accounts/addaccountdialog.cpp 4df292f 
>   choqok/config/accounts/editaccountdialog.cpp 4095d67 
>   choqok/config/appearance/appearanceconfig.h 6015728 
>   choqok/config/appearance/appearanceconfig.cpp 1cefc52 
>   choqok/config/behavior/behaviorconfig.h 40c2831 
>   choqok/config/behavior/behaviorconfig.cpp a6f6c2d 
>   choqok/config/behavior/behaviorconfig_shorten.h edfce18 
>   choqok/config/behavior/behaviorconfig_shorten.cpp a529c53 
>   choqok/config/plugins/choqokpluginconfig.h f0729e7 
>   choqok/config/plugins/choqokpluginconfig.cpp e57b533 
>   choqok/main.cpp 931bd91 
>   choqok/mainwindow.h e28bc0c 
>   choqok/mainwindow.cpp 065615c 
>   choqok/systrayicon.h 15a792d 
>   choqok/systrayicon.cpp fcbd40f 
>   helperlibs/twitterapihelper/twitterapiaccount.h d880f14 
>   helperlibs/twitterapihelper/twitterapiaccount.cpp 7205a2b 
>   helperlibs/twitterapihelper/twitterapicomposerwidget.h 7afb2e7 
>   helperlibs/twitterapihelper/twitterapicomposerwidget.cpp c459af4 
>   helperlibs/twitterapihelper/twitterapidmessagedialog.h ed36a1d 
>   helperlibs/twitterapihelper/twitterapidmessagedialog.cpp 6a8c045 
>   helperlibs/twitterapihelper/twitterapimicroblog.h 75a9f77 
>   helperlibs/twitterapihelper/twitterapimicroblog.cpp 419ecdd 
>   helperlibs/twitterapihelper/twitterapimicroblogwidget.cpp db28994 
>   helperlibs/twitterapihelper/twitterapipostwidget.h cda3512 
>   helperlibs/twitterapihelper/twitterapisearch.h b421585 
>   helperlibs/twitterapihelper/twitterapisearch.cpp b3078c4 
>   helperlibs/twitterapihelper/twitterapisearchdialog.h e05b61a 
>   helperlibs/twitterapihelper/twitterapisearchdialog.cpp 55b999c 
>   helperlibs/twitterapihelper/twitterapisearchtimelinewidget.cpp 82dc1b1 
>   helperlibs/twitterapihelper/twitterapishowthread.h e8eafb1 
>   helperlibs/twitterapihelper/twitterapishowthread.cpp 87063ce 
>   helperlibs/twitterapihelper/twitterapitextedit.cpp 0631cb9 
>   helperlibs/twitterapihelper/twitterapitimelinewidget.h 7c0f784 
>   helperlibs/twitterapihelper/twitterapitimelinewidget.cpp 735979b 
>   helperlibs/twitterapihelper/twitterapiwhoiswidget.h 7579ea0 
>   helperlibs/twitterapihelper/twitterapiwhoiswidget.cpp d2ee6d7 
>   libchoqok/account.h cbe7b5f 
>   libchoqok/account.cpp 26f4245 
>   libchoqok/accountmanager.h 7af3ebc 
>   libchoqok/accountmanager.cpp cfc90de 
>   libchoqok/application.h 20a7019 
>   libchoqok/choqokid.h 080e29b 
>   libchoqok/choqoktools.h 8238ced 
>   libchoqok/choqoktools.cpp d77a497 
>   libchoqok/choqoktypes.h ea86732 
>   libchoqok/choqokuiglobal.h e4f52fe 
>   libchoqok/choqokuiglobal.cpp 2693f82 
>   libchoqok/dbushandler.h c14c6a2 
>   libchoqok/dbushandler.cpp 568b987 
>   libchoqok/indicatormanager.h 8618de7 
>   libchoqok/indicatormanager.cpp f0b6b7e 
>   libchoqok/mediamanager.h 0241f9e 
>   libchoqok/mediamanager.cpp 2cb5aef 
>   libchoqok/microblog.h a564daf 
>   libchoqok/microblog.cpp b717169 
>   libchoqok/notifymanager.h 8bcaff8 
>   libchoqok/notifymanager.cpp 1fc12ba 
>   libchoqok/passwordmanager.h 1938712 
>   libchoqok/passwordmanager.cpp 6ad9c7c 
>   libchoqok/plugin.h 91d81cf 
>   libchoqok/plugin.cpp 3f50499 
> 
> Diff: https://git.reviewboard.kde.org/r/122567/diff/
> 
> 
> Testing
> -------
> 
> Still builds.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20150215/bea4d319/attachment-0001.html>

More information about the Choqok-devel mailing list