Review Request 121652: Use statuses/user_timeline.json API instead of search/tweets.json API for user timelines

[Ian Schwarz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121652/
-----------------------------------------------------------

(Updated Aug. 10, 2015, 9:25 a.m.)


Status
------

This change has been discarded.


Review request for Choqok.


Repository: choqok


Description
-------

For "Posts from $USER", Choqok should use Twitter's "statuses/user_timeline.json" API instead of the "search/tweets.json" API it uses for everything else. The reason for this is that the search API is not exhaustive (i.e. it does not necessarily return ALL tweets by a user) and will, in any case, only return tweets that are 7 days old (or newer). The "statuses/user_timeline.json" API returns up to 3,200 tweets of any age.

See also https://reviewboard.kde.org/r/121165/.


Diffs
-----

  choqok-vanilla/microblogs/twitter/twittersearch.h 662e8d7 
  choqok-vanilla/microblogs/twitter/twittersearch.cpp da85565 
  choqok-vanilla/microblogs/laconica/laconicasearch.h 4bfac2d 
  choqok-vanilla/microblogs/laconica/laconicasearch.cpp 4b1c9c9 
  choqok-vanilla/microblogs/twitter/twitterpostwidget.cpp a07b856 
  choqok-vanilla/helperlibs/twitterapihelper/twitterapisearch.h b421585 
  choqok-vanilla/helperlibs/twitterapihelper/twitterapisearch.cpp b3078c4 

Diff: https://git.reviewboard.kde.org/r/121652/diff/


Testing
-------

Compiles and works for me, although I have only tested it briefly in this "modular" form. Testing it is rather hard because it is impossible to browse pages/display older tweets, so you have to test it with an account that has tweeted less than 100 times (max. number of results) in the last 7 days (to see if it will display older tweets).

See also https://reviewboard.kde.org/r/121165/.


Thanks,

Ian Schwarz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20150810/d4659717/attachment.html>