Review Request 116789: Show images of Twitter tweets in Choqok

Mehrdad Momeny mehrdad.momeny at gmail.com
Sun Mar 30 09:14:51 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116789/#review54576
-----------------------------------------------------------

Ship it!


Very good Daniel.
Thank you for this cool addition to Choqok.

- Mehrdad Momeny


On March 19, 2014, 7:52 p.m., Daniel Kreuter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116789/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 7:52 p.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Bugs: 299433
>     http://bugs.kde.org/show_bug.cgi?id=299433
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> Currently Choqok doesn't show images which may be part of Tweets. This bugfix adds support for images and adds them to the postwidget underneath the tweet.
> 
> 
> Diffs
> -----
> 
>   helperlibs/twitterapihelper/twitterapimicroblog.cpp f0c8296 
>   libchoqok/choqoktypes.h c8cc59c 
>   libchoqok/ui/postwidget.h da460c9 
>   libchoqok/ui/postwidget.cpp eb005ae 
> 
> Diff: https://git.reviewboard.kde.org/r/116789/diff/
> 
> 
> Testing
> -------
> 
> Tested and images are shown in the posts. If a tweet doesn't have an image, the post looks as before.
> 
> 
> Thanks,
> 
> Daniel Kreuter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20140330/97fcaf4f/attachment.html>


More information about the Choqok-devel mailing list