Review Request 116789: Show images of Twitter tweets in Choqok

[Mehrdad Momeny]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116789/#review53062
-----------------------------------------------------------


Thanks Daniel, it is better now.
But as you can see here: http://imagebin.org/299593 and here http://imagebin.org/299594 the Stylesheet is still broken, this time for others post.
Specially for Right to left languages that part of the tweet is blocked (second photo). and you still need to resize to bigger size than the photo to see the whole text.

Also, I suggest to have a little more (maybe 5px) between the Avatar and the photo for User own photos. as you can see here: http://imagebin.org/299596 but this is not a big issue as the above mentioned.

- Mehrdad Momeny


On March 15, 2014, 4:50 p.m., Daniel Kreuter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116789/
> -----------------------------------------------------------
> 
> (Updated March 15, 2014, 4:50 p.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Bugs: 299433
>     http://bugs.kde.org/show_bug.cgi?id=299433
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> Currently Choqok doesn't show images which may be part of Tweets. This bugfix adds support for images and adds them to the postwidget underneath the tweet.
> 
> 
> Diffs
> -----
> 
>   helperlibs/twitterapihelper/twitterapimicroblog.cpp f0c8296 
>   libchoqok/choqoktypes.h c8cc59c 
>   libchoqok/ui/postwidget.h da460c9 
>   libchoqok/ui/postwidget.cpp eb005ae 
> 
> Diff: https://git.reviewboard.kde.org/r/116789/diff/
> 
> 
> Testing
> -------
> 
> Tested and images are shown in the posts. If a tweet doesn't have an image, the post looks as before.
> 
> 
> Thanks,
> 
> Daniel Kreuter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20140316/814060ed/attachment.html>