Review Request 116789: Show images of Twitter tweets in Choqok

[Ahmed Ibrahim]

> On March 15, 2014, 11:09 a.m., Mehrdad Momeny wrote:
> > It's not good to keep the image in it's size! this will ruin our GUI, as you can see in this screenshot: http://imagebin.org/299447
> > 
> > I prefer the image to be smaller and even maybe resizable! I mean, if user choose to have smaller window, it doesn't push avatar or anything else out of view.
> > 
> > Also, it seems that your change corrupted current layout of User tweets! as you can see the third tweet in that screenshot.

I am with Mehrdad with his opinion, I've tried your patch and it fetches the image but it ruins the UI in a bad way.
IMHO perhaps you could load a small image like what happens with Youtube links and then wrap the <img> with an <a> that refers to the image URL.

d->mImage = QString("<td width=\"%1\" height=\"%2\"><a href=\"%3\"><img src=\"img://postImage\"  /> </a></td>").arg(QString(d->mCurrentPost->mediaSizeWidth), QString(d->mCurrentPost->mediaSizeHeight), d->imageUrl );


- Ahmed


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116789/#review52967
-----------------------------------------------------------


On March 13, 2014, 10:35 p.m., Daniel Kreuter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116789/
> -----------------------------------------------------------
> 
> (Updated March 13, 2014, 10:35 p.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Bugs: 299433
>     http://bugs.kde.org/show_bug.cgi?id=299433
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> Currently Choqok doesn't show images which may be part of Tweets. This bugfix adds support for images and adds them to the postwidget underneath the tweet.
> 
> 
> Diffs
> -----
> 
>   helperlibs/twitterapihelper/twitterapimicroblog.cpp f0c8296 
>   libchoqok/choqoktypes.h c8cc59c 
>   libchoqok/ui/postwidget.h da460c9 
>   libchoqok/ui/postwidget.cpp eb005ae 
> 
> Diff: https://git.reviewboard.kde.org/r/116789/diff/
> 
> 
> Testing
> -------
> 
> Tested and images are shown in the posts. If a tweet doesn't have an image, the post looks as before.
> 
> 
> Thanks,
> 
> Daniel Kreuter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20140315/362536a9/attachment.html>