Review Request 118535: Remove pop-up modal dialog error when starting choqok without internet connection

[Mehrdad Momeny]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118535/#review59259
-----------------------------------------------------------


Well, the reason to use Critical i.e. showing pop up message was because there's an option for user to select "update friend list" and there we should show a pop up message.

So, I think to eliminate this pop up in start up of Choqok, there's two way: 1st try updating the friends list while you are connected, so it won't try it again next time when it started up.
In code we should add a flag like thing here to this part of code to know from where this method called!? if it needs distinct result(the mentioned sceniario), we should send it with pop up, otherwise it can be a low level error.

- Mehrdad Momeny


On June 4, 2014, 5:14 p.m., Yuen Hoe Lim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118535/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 5:14 p.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> If choqok is started without internet connection, a pop up shows up saying "Friends list for account could not be updated", which is a little annoying since the status bar already has a similar error message - especially during start up where I always need to close the pop up as the first thing I do after logging into Plasma when there's no internet. Thought I'd try and investigate the code and I found it's because the friend list update error is, unlike other errors like failure to update timeline, emitted with severity "Critical". Changing this to "Low" like the others gets rid of the popup.
> 
> Is this an acceptable patch? Or is there an important reason the friends list update message is Critical? If so, then is there another better way I could patch choqok to avoid the pop up?
> 
> 
> Diffs
> -----
> 
>   helperlibs/twitterapihelper/twitterapimicroblog.cpp 317f14b 
> 
> Diff: https://git.reviewboard.kde.org/r/118535/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yuen Hoe Lim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20140605/14af533a/attachment.html>