Review Request 118455: Add option to hide systray

Mehrdad Momeny mehrdad.momeny at gmail.com
Mon Jun 2 01:22:59 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118455/#review58917
-----------------------------------------------------------



choqok/mainwindow.cpp
<https://git.reviewboard.kde.org/r/118455/#comment40994>

    It'd be better to show MainWindow here before deleting the sysIcon! 
    
    The scenario is:
    User opens preferences dialog through sys tray icon's options and select to hide the icon. then there's no way to bring up the MainWindow!


- Mehrdad Momeny


On June 1, 2014, 3:36 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118455/
> -----------------------------------------------------------
> 
> (Updated June 1, 2014, 3:36 p.m.)
> 
> 
> Review request for Choqok.
> 
> 
> Bugs: 241152
>     http://bugs.kde.org/show_bug.cgi?id=241152
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> Add a checkbox in the Behaviour settings to disable the system tray.
> 
> 
> Diffs
> -----
> 
>   choqok/config/behavior/behaviorconfig_general.ui 4263c89 
>   choqok/mainwindow.h 7b44f72 
>   choqok/mainwindow.cpp 1435c91 
>   libchoqok/choqokbehaviorsettings.kcfg b5031bb 
> 
> Diff: https://git.reviewboard.kde.org/r/118455/diff/
> 
> 
> Testing
> -------
> 
> Tried for a couple of hours with either system tray enabled and disabled.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20140602/2ee2f2fc/attachment.html>


More information about the Choqok-devel mailing list