Review Request 121652: Use statuses/user_timeline.json API instead of search/tweets.json API for user timelines

[Andrea Scarpino]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121652/#review72472
-----------------------------------------------------------



choqok-vanilla/microblogs/twitter/twittersearch.cpp
<https://git.reviewboard.kde.org/r/121652/#comment50517>

    Please remove trailing spaces while you are on it.



choqok-vanilla/microblogs/twitter/twittersearch.cpp
<https://git.reviewboard.kde.org/r/121652/#comment50516>

    Just to save some CPU cycle, you could move:
    
    QVariantList list = parsed.toList()
    
    in the "else if" body and change the if condition to (ok && !map.isEmpty())


- Andrea Scarpino


On Dec. 23, 2014, 7:54 p.m., Ian Schwarz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121652/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2014, 7:54 p.m.)
> 
> 
> Review request for Choqok.
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> For "Posts from $USER", Choqok should use Twitter's "statuses/user_timeline.json" API instead of the "search/tweets.json" API it uses for everything else. The reason for this is that the search API is not exhaustive (i.e. it does not necessarily return ALL tweets by a user) and will, in any case, only return tweets that are 7 days old (or newer). The "statuses/user_timeline.json" API returns up to 3,200 tweets of any age.
> 
> See also https://reviewboard.kde.org/r/121165/.
> 
> 
> Diffs
> -----
> 
>   choqok-vanilla/microblogs/twitter/twittersearch.h 662e8d7 
>   choqok-vanilla/microblogs/twitter/twittersearch.cpp da85565 
>   choqok-vanilla/microblogs/laconica/laconicasearch.h 4bfac2d 
>   choqok-vanilla/microblogs/laconica/laconicasearch.cpp 4b1c9c9 
>   choqok-vanilla/microblogs/twitter/twitterpostwidget.cpp a07b856 
>   choqok-vanilla/helperlibs/twitterapihelper/twitterapisearch.h b421585 
>   choqok-vanilla/helperlibs/twitterapihelper/twitterapisearch.cpp b3078c4 
> 
> Diff: https://git.reviewboard.kde.org/r/121652/diff/
> 
> 
> Testing
> -------
> 
> Compiles and works for me, although I have only tested it briefly in this "modular" form. Testing it is rather hard because it is impossible to browse pages/display older tweets, so you have to test it with an account that has tweeted less than 100 times (max. number of results) in the last 7 days (to see if it will display older tweets).
> 
> See also https://reviewboard.kde.org/r/121165/.
> 
> 
> Thanks,
> 
> Ian Schwarz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20141223/a850cc97/attachment-0001.html>