Review Request 121610: Take Twitter's t.co urls lenght in consideration

[Mehrdad Momeny]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121610/#review72445
-----------------------------------------------------------



helperlibs/twitterapihelper/twitterapitextedit.h
<https://git.reviewboard.kde.org/r/121610/#comment50487>

    Typo: Length
    ;)



helperlibs/twitterapihelper/twitterapitextedit.h
<https://git.reviewboard.kde.org/r/121610/#comment50488>

    Typo here again. ;)



helperlibs/twitterapihelper/twitterapitextedit.cpp
<https://git.reviewboard.kde.org/r/121610/#comment50489>

    Isn't it better to move this function to TwitterMicroBlog, and call this API method once for all Twitter accounts!?
    It's in fact a microblog concept! and should be there.


The rest of it is OK to me.
Just I think that the fetchTCoMaximum...() stuff is a microblog thing, and should be there. You can get the result through the account object.

- Mehrdad Momeny


On Dec. 20, 2014, 9:04 a.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121610/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2014, 9:04 a.m.)
> 
> 
> Review request for Choqok.
> 
> 
> Bugs: 285453
>     http://bugs.kde.org/show_bug.cgi?id=285453
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> See https://dev.twitter.com/docs/tco-link-wrapper for more info.
> 
> 
> Diffs
> -----
> 
>   helperlibs/twitterapihelper/twitterapicomposerwidget.cpp 8a626c5fae0818fa006f9654929efefc5f602c91 
>   helperlibs/twitterapihelper/twitterapitextedit.h 711769d8ac75f3c381c59be2dcf5df9826e837c0 
>   helperlibs/twitterapihelper/twitterapitextedit.cpp 199caca1b6305537312c0d6169b2c5124e7deb44 
>   libchoqok/CMakeLists.txt c1dae3f7ebc1d535ab2b41126c495228be04a82f 
>   libchoqok/ui/choqoktextedit.h dd8290c8c5e9c34cdcce3c0deffaacc28dce406e 
>   libchoqok/ui/choqoktextedit.cpp 2f3e45726432a3a1aa4d2ed4a427b20bacbe7ba7 
>   libchoqok/ui/postwidget.h 01ee0c5258d46dc90b5a9d82ef62263ff44e516f 
>   libchoqok/ui/postwidget.cpp 8d4d6ce15c0a199d2ee087ae8bbe1c823e1841a0 
>   libchoqok/urlutils.h PRE-CREATION 
>   libchoqok/urlutils.cpp PRE-CREATION 
>   microblogs/laconica/laconicacomposerwidget.cpp 041c92c0259b4fd8282c2c73218bee0fb417a325 
> 
> Diff: https://git.reviewboard.kde.org/r/121610/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20141223/3c2510c9/attachment.html>