Review Request 121582: fix problems with longurl plugin

[Andrea Scarpino]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121582/#review72200
-----------------------------------------------------------

Ship it!


Looks fine.


plugins/longurl/longurl.cpp
<https://git.reviewboard.kde.org/r/121582/#comment50371>

    Could you use Q_FOREACH instead?


- Andrea Scarpino


On Dec. 17, 2014, 7:27 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121582/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 7:27 p.m.)
> 
> 
> Review request for Choqok.
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> Fix memleak and hopefully a race on unloading between destructor and parser in longurl plugin
> 
> 
> Diffs
> -----
> 
>   plugins/longurl/longurl.h da322c1cdd0d8fcd0f40f403a6c9dcfbe708ef20 
>   plugins/longurl/longurl.cpp 17bb17584cfe9c116f53bb751eb6055b365c7937 
> 
> Diff: https://git.reviewboard.kde.org/r/121582/diff/
> 
> 
> Testing
> -------
> 
> No testing was done
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20141217/7a1f9ddd/attachment.html>