Review Request 121579: KDE Telepathy support in IMStatus Plugin

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121579/#review72192
-----------------------------------------------------------



plugins/imstatus/imqdbus.cpp
<https://git.reviewboard.kde.org/r/121579/#comment50355>

    I'd suggest to use m_accountManager->enabledAccounts() here.
    
    The difference is that for example the user can have 10 accounts but 6 disabled, enabledAccounts() would then return only 4 accounts rather than all 10.
    
    Making things slightly faster by not bothering with "unusable" (for this case) accounts :)



plugins/imstatus/imqdbus.cpp
<https://git.reviewboard.kde.org/r/121579/#comment50356>

    You /might/ want to add some text saying something like "AccountManager failed to get ready" << po->error...
    
    It's easier to read the output. Also telepathy error messages can be quite cryptic, so this makes it easier to understand where the error comes from.


- Martin Klapetek


On Dec. 17, 2014, 3:43 p.m., Ahmed I. Khalil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121579/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 3:43 p.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Bugs: 301702
>     http://bugs.kde.org/show_bug.cgi?id=301702
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> Refactored the IMQDBus class to be suitable for use with TelepathyQt
> Added TelepathyQt as optional dependencies and if not found do not build the IMStatus plugin.
> 
> 
> Diffs
> -----
> 
>   plugins/imstatus/CMakeLists.txt 992977286608f32373c8858f57fa9335699046b7 
>   plugins/imstatus/config-imstatus.h.cmake PRE-CREATION 
>   plugins/imstatus/imqdbus.h 97e7b2f6a7809f294ffcc443822412be4ce2f7af 
>   plugins/imstatus/imqdbus.cpp ce2580bd9ea861cf0df8c3d31a4f3373cb312bd5 
>   plugins/imstatus/imstatus.h 5f49451387584ce7f8a8c917b38219e469cd25c2 
>   plugins/imstatus/imstatus.cpp e8817fed179a6a652a04096fe84412e843de3a13 
> 
> Diff: https://git.reviewboard.kde.org/r/121579/diff/
> 
> 
> Testing
> -------
> 
> Posted a post using the Quick post widget, and the status changed to all the online accounts in KDE Telepathy
> 
> 
> Thanks,
> 
> Ahmed I. Khalil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20141217/189f85c4/attachment-0001.html>