Review Request 121576: Fix memleaks in image fetching

[Eugene Shalygin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121576/
-----------------------------------------------------------

(Updated Dec. 17, 2014, 1:48 p.m.)


Status
------

This change has been marked as submitted.


Review request for Choqok.


Bugs: 341927
    http://bugs.kde.org/show_bug.cgi?id=341927


Repository: choqok


Description
-------

As it is described in the referenced bug, Choqok is leaking memory. Valgrind pointed to the QPixmap managment in MediaManager::fetchImage() and its callers.


Diffs
-----

  helperlibs/twitterapihelper/twitterapiwhoiswidget.cpp 806eb37 
  libchoqok/mediamanager.h 7851f31 
  libchoqok/mediamanager.cpp c9e6126 
  libchoqok/ui/postwidget.cpp 7d441e4 
  plugins/betternotify/notification.cpp 5392198 

Diff: https://git.reviewboard.kde.org/r/121576/diff/


Testing
-------

With this patch applied my Choqok's memmory usage is at 152 MB for a half of the day, instead of GBs


Thanks,

Eugene Shalygin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20141217/c47dc89d/attachment-0001.html>