Review Request 121579: KDE Telepathy support in IMStatus Plugin
Andrea Scarpino
scarpino at kde.org
Wed Dec 17 13:20:07 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121579/#review72179
-----------------------------------------------------------
plugins/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121579/#comment50346>
This will not build the imstatus plugin without telepathy and it's not OK since it works with Kopete, Pidgin and more.
- Andrea Scarpino
On Dic. 17, 2014, 1:43 p.m., Ahmed I. Khalil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121579/
> -----------------------------------------------------------
>
> (Updated Dic. 17, 2014, 1:43 p.m.)
>
>
> Review request for Choqok and Mehrdad Momeny.
>
>
> Repository: choqok
>
>
> Description
> -------
>
> Refactored the IMQDBus class to be suitable for use with TelepathyQt
> Added TelepathyQt as optional dependencies and if not found do not build the IMStatus plugin.
>
>
> Diffs
> -----
>
> CMakeLists.txt a37bb748e1f65c7e661644d654905d0bdf18d793
> plugins/CMakeLists.txt 856e3ce5056e3093242e1619a630d8c262228576
> plugins/imstatus/CMakeLists.txt 992977286608f32373c8858f57fa9335699046b7
> plugins/imstatus/imqdbus.h 97e7b2f6a7809f294ffcc443822412be4ce2f7af
> plugins/imstatus/imqdbus.cpp ce2580bd9ea861cf0df8c3d31a4f3373cb312bd5
> plugins/imstatus/imstatus.h 5f49451387584ce7f8a8c917b38219e469cd25c2
> plugins/imstatus/imstatus.cpp e8817fed179a6a652a04096fe84412e843de3a13
>
> Diff: https://git.reviewboard.kde.org/r/121579/diff/
>
>
> Testing
> -------
>
> Posted a post using the Quick post widget, and the status changed to all the online accounts in KDE Telepathy
>
>
> Thanks,
>
> Ahmed I. Khalil
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20141217/5aa0d17e/attachment.html>
More information about the Choqok-devel
mailing list