Review Request 121451: Add url expansion plugin that utilizes longurl.org service

[Mehrdad Momeny]

> On Dec. 15, 2014, 3:19 p.m., Mehrdad Momeny wrote:
> > Ship It!
> 
> Andrea Scarpino wrote:
>     Should we drop UnTiny then?
>     (I agree)
> 
> Eugene Shalygin wrote:
>     I have no commit rights, so please do it for me

Yes, just remove the untiny plugin from build.


- Mehrdad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121451/#review72062
-----------------------------------------------------------


On Dec. 15, 2014, 5:10 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121451/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2014, 5:10 p.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Bugs: 294600
>     http://bugs.kde.org/show_bug.cgi?id=294600
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> KDEWebkit does not implement redirection signals and thus UnTiny plugin does not work in this case. 
> The code was "stolen" from ktp-text-ui.
> 
> There is a problem: is it possible to disable the other one of these two plugins (UnTiny/LongUrl) when one of the pair is enabled?
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt bea499b 
>   plugins/longurl/CMakeLists.txt PRE-CREATION 
>   plugins/longurl/choqok_longurl.desktop PRE-CREATION 
>   plugins/longurl/longurl.h PRE-CREATION 
>   plugins/longurl/longurl.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121451/diff/
> 
> 
> Testing
> -------
> 
> Manual testing + video preview started to work with this URL expansion
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20141216/5ea634fa/attachment.html>