Review Request 121451: Add url expansion plugin that utilize longurl.org service

[Mehrdad Momeny]

> On Dec. 12, 2014, 5 p.m., Andrea Scarpino wrote:
> > I guess we can't disable them.
> > The only option is to write some info about this conflict in the summary line.

Hmm, I guess these doesn't have any conflict in action.
But then if this plugin works fine, we can just remove the untiny plugin from build for this release.
What we did before for translate plugin and it's still disabled.


- Mehrdad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121451/#review71889
-----------------------------------------------------------


On Dec. 11, 2014, 5:01 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121451/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 5:01 p.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Bugs: 294600
>     http://bugs.kde.org/show_bug.cgi?id=294600
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> KDEWebkit does not implement redirection signals and thus UnTiny plugin does not work in this case. 
> The code was "stolen" from ktp-text-ui.
> 
> There is a problem: is it possible to disable the other one of these two plugins (UnTiny/LongUrl) when one of the pair is enabled?
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt bea499b 
>   plugins/longurl/CMakeLists.txt PRE-CREATION 
>   plugins/longurl/choqok_longurl.desktop PRE-CREATION 
>   plugins/longurl/longurl.h PRE-CREATION 
>   plugins/longurl/longurl.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121451/diff/
> 
> 
> Testing
> -------
> 
> Manual testing + video preview started to work with this URL expansion
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20141213/d1ca4bc3/attachment.html>