Review Request 111181: Add 'mark as read' to timeline menu

Mehrdad Momeny mehrdad.momeny at gmail.com
Mon Jun 24 03:19:57 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111181/#review34936
-----------------------------------------------------------



helperlibs/twitterapihelper/twitterapimicroblogwidget.cpp
<http://git.reviewboard.kde.org/r/111181/#comment25586>

    sWidget is already defined as a TimelineWidget in line 259: [Choqok::UI::TimelineWidget *sWidget]
    So there's no need to cast it again! isn't it?


- Mehrdad Momeny


On June 22, 2013, 5:21 p.m., Yuen Hoe Lim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111181/
> -----------------------------------------------------------
> 
> (Updated June 22, 2013, 5:21 p.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Description
> -------
> 
> As requested in the bugtest/maillist: small patch to add a 'mark all as read' item to the timeline tab context menu.
> 
> 
> This addresses bug 287684.
>     http://bugs.kde.org/show_bug.cgi?id=287684
> 
> 
> Diffs
> -----
> 
>   helperlibs/twitterapihelper/twitterapimicroblogwidget.cpp 6e91e32 
> 
> Diff: http://git.reviewboard.kde.org/r/111181/diff/
> 
> 
> Testing
> -------
> 
> basic testing on my box.
> 
> 
> Thanks,
> 
> Yuen Hoe Lim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20130624/3e36b45d/attachment.html>


More information about the Choqok-devel mailing list