Refactoring plans

Daniel Kreuter daniel.kreuter85 at gmail.com
Thu Jun 20 09:32:22 UTC 2013


For twitter, we don't need XML support because the new a pi doesn't support
it. This doesn't mean that there won't be another storage solution in the
future but for now the first approach which would only affect twitter will
do it.

For pump.io this is a different topic which will be addressed in it's own
lib.
On Jun 20, 2013 9:47 AM, "Luis Angel Fernandez Fernandez" <laffdez at gmail.com>
wrote:

>
> 2013/6/20 Daniel Kreuter <daniel.kreuter85 at gmail.com>
>
>>
>> First one:
>> Since we now only have JSON, a simple renaming from readPostFromJson
>> to readPost (as wel for the other methods) would do it.
>>
>> Second way:
>> Introduce an abstract class or an interface which defines the methods
>> and implement it with the appropriate type (f.e. one for json, one for
>> xml and so on).
>> This way we can construct the appropriate type based on the format
>> used, and have one interface which rules them all.
>>
>> The benefit of both ways would be, that the code is more maintainable.
>> No need to check for the format do call the correct version.
>>
>> What's your opinion?
>>
>
>   Is/Will be there any need for keeping the XML support? If there is no
> need I'd vote for the first approach. If the XML support needs to be kept
> then I'd vote for the second approach.
>
>   But I have a question. Since yo want to go into this refactoring thing
> :-). Would it be a good idea to use the work Martin Klapetek did with his
> akonadi plugin and the develop the pump.io support as an akonadi plugin?
>
> --
> Linkedin profile (http://es.linkedin.com/in/lafdez)
> G+ profile (https://plus.google.com/u/0/115320207805121303027/about)
> Twitter (@lafdez @_lafdez_)
> Identi.ca (@lafdez)
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20130620/1651a2d0/attachment.html>


More information about the Choqok-devel mailing list