Review Request 111394: Refactoring of method names in the twitter api

Mehrdad Momeny mehrdad.momeny at gmail.com
Fri Jul 5 03:29:54 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111394/#review35610
-----------------------------------------------------------

Ship it!


Ship It!

- Mehrdad Momeny


On July 4, 2013, 4:12 p.m., Daniel Kreuter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111394/
> -----------------------------------------------------------
> 
> (Updated July 4, 2013, 4:12 p.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Description
> -------
> 
> Since we don't have XML support anymore there is no need for methods ending with fromJSON or fromXML or similar.
> Refactored the code to be more readable.
> 
> 
> Diffs
> -----
> 
>   helperlibs/twitterapihelper/twitterapimicroblog.h 59c88b3 
>   helperlibs/twitterapihelper/twitterapimicroblog.cpp 1ad6823 
>   microblogs/laconica/laconicamicroblog.cpp f5585d1 
>   microblogs/twitter/twittermicroblog.cpp fa08879 
> 
> Diff: http://git.reviewboard.kde.org/r/111394/diff/
> 
> 
> Testing
> -------
> 
> Code compiles and everything works fine.
> 
> 
> Thanks,
> 
> Daniel Kreuter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20130705/7afd0b4b/attachment.html>


More information about the Choqok-devel mailing list