Review Request 111180: Save search even if empty

[Mehrdad Momeny]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111180/#review35423
-----------------------------------------------------------



helperlibs/twitterapihelper/twitterapimicroblogwidget.cpp
<http://git.reviewboard.kde.org/r/111180/#comment25951>

    It's better to put all of this text inside i18n() call. don't need to put "(" & ")" outside.



libchoqok/ui/timelinewidget.cpp
<http://git.reviewboard.kde.org/r/111180/#comment25952>

    It would be better to just remove/delete the label, because we don't need it any longer.


- Mehrdad Momeny


On June 25, 2013, 7:12 p.m., Yuen Hoe Lim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111180/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 7:12 p.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Description
> -------
> 
> As requested in the bug text/email in the maillist: small patch to create the search tab even if search results are empty.
> 
> One thing I noticed though: since the error message dialog is still there, this means that if I leave the search tab there and then quit choqok, and then start choqok again another day, choqok will load the empty tab and show the error alert again, which is probably not so nice. Should I do something about that too?
> 
> 
> This addresses bug 319150.
>     http://bugs.kde.org/show_bug.cgi?id=319150
> 
> 
> Diffs
> -----
> 
>   helperlibs/twitterapihelper/twitterapimicroblogwidget.cpp 6e91e32 
>   libchoqok/ui/timelinewidget.h c1e881d 
>   libchoqok/ui/timelinewidget.cpp 7cb1db5 
> 
> Diff: http://git.reviewboard.kde.org/r/111180/diff/
> 
> 
> Testing
> -------
> 
> Simple testing on my system.
> 
> 
> Thanks,
> 
> Yuen Hoe Lim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20130702/554b5043/attachment.html>