Review Request 114022: Set input box size based on font size

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114022/#review46428
-----------------------------------------------------------


This review has been submitted with commit 091b215dea565cf73b6209396726adc9fc2566cb by Andrea Scarpino on behalf of Mehrdad Momeny to branch master.

- Commit Hook


On Dec. 28, 2013, 5:24 p.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114022/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2013, 5:24 p.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Bugs: 317690
>     http://bugs.kde.org/show_bug.cgi?id=317690
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> Choqok's TextEdit uses the minimum length of the scrollbar as it's height (through QAbstractScrollArea::minimumSizeHint) and it also sets a hard limit on the height of the editor. These cause two problem:
> 1. The height of the TextEdit is theme dependent and for a theme that allows short scrollbar (which is perfectly legal), the text box can be too small.
> 2. When the use specifies a larger font (e.g. 32-72) the TextEditor will not expand along with it leaving only one (or less) visible lines.
> 
> 
> Diffs
> -----
> 
>   libchoqok/ui/choqoktextedit.h 61e7e24 
>   libchoqok/ui/choqoktextedit.cpp bc92384 
>   libchoqok/ui/composerwidget.cpp 16f5538 
> 
> Diff: https://git.reviewboard.kde.org/r/114022/diff/
> 
> 
> Testing
> -------
> 
> Compiles. TextEdit (inside ComposeWidget) has a height of ~1 line when empty and ~3 lines when not. Tested for
> 1. When the theme allows short scrollbar (by returning small values in pixelMetric(QStyle::PM_ScrollBarSliderMin) and sizeFromContents(QStyle::CT_ScrollBar))
> 2. When selecting a big font (32pt)
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20131230/06f269fc/attachment-0001.html>