Review Request 112171: Don't lose saved searches when no connection

[Mehrdad Momeny]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112171/#review38354
-----------------------------------------------------------

Ship it!


Thanks for fix,

- Mehrdad Momeny


On Aug. 20, 2013, 7:59 a.m., Yuen Hoe Lim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112171/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2013, 7:59 a.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Description
> -------
> 
> Performing a search on choqok "saves" it as a new tab, in the sense that as long as the tab isn't manually closed, the search results continue to be updated, and they also get reloaded if you exit and start choqok again. However, if choqok is started when there is no internet connection, the search tabs aren't created, meaning the saved searches are lost and won't come back even after internet connection is restored. I think this qualifies as buggy behavior, and so this is a small patch to address that.
> 
> All it does is it makes sure to still create the saved search tabs (with no results) even when there is no internet connection. This prevents the tabs from becoming lost, and the search results are automatically loaded in when internet connection is later restored.
> 
> 
> Diffs
> -----
> 
>   microblogs/twitter/twittersearch.cpp dee43b2 
> 
> Diff: http://git.reviewboard.kde.org/r/112171/diff/
> 
> 
> Testing
> -------
> 
> Simple testing on my machine
> 
> 
> Thanks,
> 
> Yuen Hoe Lim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20130822/e00bbf79/attachment.html>