Review Request 111855: Updatet user list timelines to new API version of twitter

[Mehrdad Momeny]

> On Aug. 5, 2013, 3:12 p.m., Mehrdad Momeny wrote:
> > It would be better to switch to the newly added timeline just like when a new search is done and it's timeline added!
> 
> Daniel Kreuter wrote:
>     Hi,
>     
>     from a usability point of view you're right. But I only changed the api so that the timeline gets downloaded again so this is the way Choqok worked before the API change.
>     
>     If you think, we should change it before 1.4 then I'll try to have a look at it if I find the appropriate code snippet to change this behavior.

Yes we need to switch to the newly opened tab.
But I can't recall if it was this way or that before API change.
BTW, you can commit this and work on that tab changing separately, It shouldn't be hard because we already have it for search, just check its code


- Mehrdad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111855/#review37136
-----------------------------------------------------------


On Aug. 5, 2013, 7:54 a.m., Daniel Kreuter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111855/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2013, 7:54 a.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Description
> -------
> 
> The timelines of userlists will be loaded with this patch again.
> 
> 
> This addresses bug 264091.
>     http://bugs.kde.org/show_bug.cgi?id=264091
> 
> 
> Diffs
> -----
> 
>   helperlibs/twitterapihelper/twitterapimicroblog.cpp e1412cc 
>   microblogs/twitter/twittermicroblog.cpp 7d80165 
> 
> Diff: http://git.reviewboard.kde.org/r/111855/diff/
> 
> 
> Testing
> -------
> 
> Add a userlist and load the timelines. The Twitter posts of this list should appear in the view.
> 
> 
> Thanks,
> 
> Daniel Kreuter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20130806/88752d39/attachment.html>