D25422: Handle custom-shapes to display text in ODP files

[Pekka Vuorela]

pvuorela added a comment.


  Don't know this shape stuff that well, but text shape plugin handling custom-shape feels suspicious.

INLINE COMMENTS

> TextShape.cpp:368
> +        answer = loadOdfFrameElement(element, context);
> +    }
>      m_textShapeData->document()->setUndoRedoEnabled(true);

Wondering why loadOdfFrame does such for table first, but this then handling custom-shape on different place.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25422

To: mphilippov, denexter, davidllewellynjones, pvuorela, dcaliste
Cc: denexter, pvuorela, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20200103/4632f06d/attachment.htm>