D25035: Fix incorrect conditional styling of spreadsheet cells.

Andrew den Exter noreply at phabricator.kde.org
Tue Oct 29 06:58:08 GMT 2019


denexter created this revision.
denexter added a reviewer: pvuorela.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
denexter requested review of this revision.

REVISION SUMMARY
  Include the conditions default style when comparing equality and calculating the hash to reduce instances of false equivalency.
  
        
  
  Then remove the QMap index cache since sorting on a hash an item may still produce unstable results in the somewhat unlikely case of a hash collision and it's going to take a lot of items before building and searching the map starts to be less expensive than a linear scan.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25035

AFFECTED FILES
  sheets/Condition.cpp
  sheets/RectStorage.h

To: denexter, pvuorela
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20191029/e2642aa0/attachment.htm>


More information about the calligra-devel mailing list