D25031: Don't allow an unrecognized child element to block loading of a shape plugin.

Andrew den Exter noreply at phabricator.kde.org
Tue Oct 29 06:08:02 GMT 2019


denexter created this revision.
denexter added a reviewer: pvuorela.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
denexter requested review of this revision.

REVISION SUMMARY
  If an object element has child elements but no shape plugin can be resolved for any of them fall back to trying to create a plugin from the root element.
  
  This guards against cases like the snippet below where an experimental tag has been embedded in an element which would have otherwise correctly loaded the charts plugin.
  
  <draw:object draw:notify-on-update-of-ranges="Лист1.B2 <https://phabricator.kde.org/B2>:Лист1.B12 <https://phabricator.kde.org/B12>" xlink:href="./Object 1" xlink:type="simple" xlink:show="embed" xlink:actuate="onLoad">
  
    <loext:p />
  
  </draw:object>

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25031

AFFECTED FILES
  libs/flake/KoShapeRegistry.cpp

To: denexter, pvuorela
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20191029/0c9276e1/attachment.htm>


More information about the calligra-devel mailing list